#30558: Namecoin support for onion sites in Tor Browser --------------------------------------+-------------------------------- Reporter: arthuredelstein | Owner: JeremyRand Type: defect | Status: needs_revision Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: TorBrowserTeam201911 | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: --------------------------------------+--------------------------------
Comment (by gk): Replying to [comment:17 JeremyRand]: > Thanks for the feedback Georg. I've just pushed a revised set of patches (same branch as before; Git commit hash `26c5593a9230e22b52b03917ad274b8ea08a70b5`) that I believe addresses your review so far. > > > Alas, I don't have time to review everything at once. My current plan is to go commit by commit and let you fix up things as we go. I hope this works for you. > > Yes, in fact that's better than reviewing everything at once, since it lets me start addressing feedback sooner. > > > I guess that hard-coding is done by taking the Tor Browser default values? One thing to keep in mind is that not every user is using 9150 as the SOCKS port. I don't know how hard it is to make this more dynamic but it would be nice if it were possible (but it's not necessary for a nightly inclusion). > > Doing this the "right way" will probably require patching Electrum-NMC; I'll put it on my to-do list. That said, can you elaborate on what types of users will be using a non-default SOCKS IP/port? The only cases I can think of are setups like Tails and Whonix, and those setups will need other changes to work with Namecoin because they use a control port filter that will interfere with StemNS. I definitely want to support those use cases (if nothing else because Whonix is my daily driver OS), but I'm curious if there's another set of use cases where this matters that I'm not aware of. We have users that want to avoid using Tor Browser's tor but rather like to point to a system tor which they have running anyway. Granted, it's not the majority of users (by far) but it's an important use-case we support at least. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:18> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs