#32465: Use gorilla websocket instead of x/net websocket in proxy-go -------------------------------------+-------------------------------- Reporter: arlolra | Owner: arlolra Type: defect | Status: needs_revision Priority: Medium | Milestone: Component: Circumvention/Snowflake | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -------------------------------------+-------------------------------- Changes (by cohosh):
* status: needs_review => needs_revision Comment: Thanks arlo! This looks good, and while I appreciate the refactor of `CopyLoop` into a common library, I fear that we will be undoing this with the changes in #29206 (see the [https://github.com/cohosh/snowflake/compare/sequencing2_squashed most recent candidate]). Not only are we encapsulating the web socket connection on the side inside a `SnowflakeConn`, we also handle the data received differently on the server side than the proxy side by using something similar to the `ConnMap` of Turbo Tunnel. So for now I'd suggest keeping the shared library but hold off on moving the `proxy` function to it. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32465#comment:3> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs