#32798: Compile every header by itself as part of "make check" --------------------------+------------------------------------ Reporter: teor | Owner: teor Type: task | Status: needs_revision Priority: Medium | Milestone: Tor: 0.4.3.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: | Actual Points: 1.3 Parent ID: #32764 | Points: 2 Reviewer: nickm, teor | Sponsor: --------------------------+------------------------------------
Comment (by teor): Replying to [comment:7 nickm]: > Looks good! > > I've left a couple of short questions on the PR. Also, CI is now failing because we don't have a declaration for ucontext_t in backtrace.c. Hmm, so the ucontext header doesn't define struct ucontext_t? I don't know how to work around that? Should we be doing a forward type declaration instead? > I'll try to think about the CFLAGS issue; at first glance I think it needs to be an environment variable. Same with CC, etc. I don't know if I'll get to actual implementation on those before I go on break, though. I wonder if we should actually be running this test via automake? Then we'd get a lot of these things for free. > Also we should stick our license statement at the head of the file. Ok. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32798#comment:8> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs