#32921: Code and script changes to run clang-format without breaking checkSpaces or coccinelle ----------------------------+------------------------------------ Reporter: nickm | Owner: nickm Type: enhancement | Status: needs_review Priority: Medium | Milestone: Tor: 0.4.3.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: style, 043-can | Actual Points: 1.5 Parent ID: #29226 | Points: Reviewer: catalyst | Sponsor: ----------------------------+------------------------------------
Comment (by teor): We're using Ubuntu bionic in Travis: https://gitweb.torproject.org/tor.git/tree/.travis.yml#n104 And it has clang-format-6.0: https://packages.ubuntu.com/bionic/clang-format So if we want to use clang-format in our CI, to check that code has been formatted before merging to master, we can't require a clang-format version higher than 6.0. If we don't want to use clang-format in CI, here are our options: Ubuntu releases have: * xenial: 6.0 * bionic: 6.0 * disco: 8.0 * eoan: 9.0 https://packages.ubuntu.com/search?keywords=clang- format&searchon=names&suite=all§ion=all Debian has: * stretch: 3.8 * buster: 7.0 https://packages.debian.org/search?keywords=clang- format&searchon=names&suite=all§ion=all macOS has: * Xcode doesn't install clang-format * Homebrew: 9.0 https://formulae.brew.sh/formula/clang-format The ideal version to require for developers would be 6.0. The highest reasonable version we could require is 7.0, and even then, we'd be forcing Ubuntu users to upgrade to Ubuntu disco. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32921#comment:7> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs