#28992: Bug: ../src/feature/hs/hs_client.c:571: send_introduce1: Non-fatal assertion !(ip == NULL) failed. -------------------------------------------------+------------------------- Reporter: traumschule | Owner: (none) Type: defect | Status: | needs_review Priority: Medium | Milestone: Tor: | 0.4.3.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-hs, 043-must, 035-backport, | Actual Points: 041-backport, 042-backport | Parent ID: | Points: 0.1 Reviewer: asn | Sponsor: | Sponsor27-can -------------------------------------------------+------------------------- Changes (by dgoulet):
* status: reopened => needs_review * cc: asn, dgoulet (removed) * points: => 0.1 * sponsor: => Sponsor27-can * milestone: Tor: 0.4.0.x-final => Tor: 0.4.3.x-final * keywords: tor-hs => tor-hs, 043-must, 035-backport, 041-backport, 042-backport * reviewer: => asn Comment: Ok, I think we are at the point of removing that `BUG()`. Between the rendezvous circuit creation and when we send the INTRO point, the descriptor can change "naturally" so we should stop thinking we can control all code path there and just recover which is what the code already does. I even propose that we backport else we'll get these warnings for the next half decade... I've done the patch (trivial). Here is what I propose: Branch: `ticket28992_035_01` PR: https://github.com/torproject/tor/pull/1707 (merges cleanly forward.) -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28992#comment:4> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs