#19026: Remove local LAN address ICE candidates -------------------------------------+-------------------------------- Reporter: dcf | Owner: arlolra Type: enhancement | Status: needs_revision Priority: Medium | Milestone: Component: Circumvention/Snowflake | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: cohosh | Sponsor: -------------------------------------+-------------------------------- Changes (by cohosh):
* status: needs_review => needs_revision Comment: Thanks for working on this! Thanks for keeping the option to leave the local addresses in as well. That's unfortunate that the `"public"` `RTCIceTransportPolicy` was removed from the specification. It would be nicer if we could prevent the candidate from being included in the SDP instead of grepping for it afterwards, but I don't see a way to do that with the `OnICECandidate` callback. Some comments: - {{{FIXME: Should this check ip.IsLoopback() and others?}}} I'd like to include `0.0.0.0` and `127.0.0.1` addresses in this, especially after dcf found #33157. - Let's expand the tests and include one for each type of local address - It's worth implementing this for each of the proxies as well. - Is there a way for us to use the other built-in functions in the `net` package for determining whether or not the IP address is local? -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19026#comment:6> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs