#30196: Add the tor version to the sbws bandwidth file header
---------------------------+-----------------------------------
Reporter: teor | Owner: (none)
Type: enhancement | Status: merge_ready
Priority: High | Milestone: sbws: 1.2.x-final
Component: Core Tor/sbws | Version:
Severity: Major | Resolution:
Keywords: sbws-roadmap | Actual Points:
Parent ID: #33121 | Points: 1
Reviewer: ahf | Sponsor:
---------------------------+-----------------------------------
Comment (by juga):
Replying to [comment:18 teor]:
> Hi Juga,
>
> I made a few comments on the pull request.
>
> Replying to [comment:17 juga]:
> > Replying to [comment:16 ahf]:
> > > I think both the spec change and the sbws changes are good, but I
have two questions:
> > >
> > > 1. What is the purpose of the `xxx`'s with 'tech-dept'? Is the goal
we go back here and do something actionable and is that something that is
best to have in the code rather than in tickets?
> >
> > If i'd create a ticket with a tech-debt (i guess i wrote a typo there)
changes, i don't know if it'll ever be solved and then in the ticket would
need to point to all the parts of the code where i detected it while
working on something else.
> >
> > > 2. The constant renaming seems OK to me, but it seems complicated to
maintain all these lists and how they are subsets/supersets of each other?
> >
> > agree, do you have a suggestion on how to change that without having
to increase minor version because changing API?
>
> The names of internal constants like HEADER_KEYS_V1_1_ORDERED aren't
part of the API, so they don't need a version change.
i know, that's why i did the changes
>
> What changes are you thinking about? How do they change the API?
none, that's why i replied to ahf question in point 2. in
https://trac.torproject.org/projects/tor/ticket/30196?replyto=18#comment:16
with other question.
i have ideas on changes, but they would change the API
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30196#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
[email protected]
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
