#24384: Decode percent-encoded characters in qualified search terms -----------------------------+------------------------------- Reporter: karsten | Owner: metrics-team Type: defect | Status: needs_review Priority: Medium | Milestone: Onionoo 2.0.0 Component: Metrics/Onionoo | Version: Severity: Normal | Resolution: Keywords: | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: -----------------------------+------------------------------- Changes (by karsten):
* status: needs_revision => needs_review Comment: I once more spent way more time on this ticket as I should. I feel like we made this more complex than necessary. Trying to summarize my findings: - Onionoo should decode percent-encoded characters in all its parameters including the search parameter. - Onionoo shouldn't accept + where it would otherwise expect a space. If clients care to escape spaces, they can percent-encode them, which Onionoo should understand. - That Relay Search change above looks reasonable to me, and we should rebase and merge it. And if it's still insufficient we can make another change. - I'd rather want to avoid writing a search and query specification at this point. Honestly, I can only spend a limited number of hours on character encoding topics before going mad. I made a new patch implementing these two Onionoo changes. Please review [https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-24384-2&id=c23de2f4d80bbfea99733ae3b490407ba04a0f4a commit c23de2f in my task-24384-2 branch]. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24384#comment:19> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs