#33897: Remove buffering from WebRTCPeer -------------------------------------+------------------------------ Reporter: dcf | Owner: dcf Type: enhancement | Status: needs_review Priority: Medium | Milestone: Component: Circumvention/Snowflake | Version: Severity: Normal | Resolution: Keywords: turbotunnel | Actual Points: Parent ID: | Points: Reviewer: cohosh | Sponsor: -------------------------------------+------------------------------
Comment (by dcf): Replying to [comment:4 cohosh]: > `broker.Negotiate()` can still return a `nil` answer and we're no longer checking for that [https://gitweb.torproject.org/pluggable- transports/snowflake.git/tree/client/lib/webrtc.go#n268 like we used to]. At first glance, it looks like it '''shouldn't''' return a nil answer and a non-nil error, but `util.DeserializeSessionDescription` [https://gitweb.torproject.org/pluggable- transports/snowflake.git/tree/common/util/util.go#n21 can return a nil value] without an error attached to it which would cause problems. That's a great catch. Indeed I looked at `broker.Negotiate` quickly and wrongly decided that it wouldn't return `(nil, nil)`. Here's a new branch to review. The only difference is [https://gitweb.torproject.org/user/dcf/snowflake.git/commit/?h=bug33897_2&id=b48fb781ee15cf033efc61496746a295dc0d63c7 this patch] to make `util.DeserializeSessionDescription` and `util.SerializeSessionDescription` return an error. https://gitweb.torproject.org/user/dcf/snowflake.git/log/?h=bug33897_2&id=047d3214bfb46de07e5d9f223e4fb1ba24584c8a https://gitweb.torproject.org/user/dcf/snowflake.git/diff/?h=bug33897_2&id=047d3214bfb46de07e5d9f223e4fb1ba24584c8a&id2=76732155e7d730573b3ced62209e4e1e4ead511c -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33897#comment:5> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs