#33576: Update pion-webrtc version to 2.2.3 ----------------------------------------------+---------------------------- Reporter: cohosh | Owner: tbb-team Type: defect | Status: | needs_information Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: snowflake, TorBrowserTeam202004R | Actual Points: Parent ID: | Points: Reviewer: boklm | Sponsor: ----------------------------------------------+---------------------------- Changes (by sysrqb):
* status: needs_review => needs_information Comment: This all looks good except for two pieces. {{{ diff --git a/projects/pion-webrtc/config b/projects/pion-webrtc/config index c27a3df1..d66b3bf1 100644 --- a/projects/pion-webrtc/config +++ b/projects/pion-webrtc/config @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' git_url: https://github.com/pion/webrtc -git_hash: 77c6e3b827e40175572fcf2894bb81ab1e8fd2c9 # v2.1.18 +git_hash: 1f448413f22d6c32d690db594748d8ad5d3812f5 # v2.1.2 }}} The hash `1f448413f22d6c32d690db594748d8ad5d3812f5` is tagged as `v2.2.3`: https://github.com/pion/webrtc/commit/1f448413f22d6c32d690db594748d8ad5d3812f5 And bumping `webrtc` to `v2.2.3` is the purpose of this ticket, so that's all...fine :) However, I wonder why `go mod graph` (or the script) think `v2.1.2` is the/a new dependency version. Do you know? Second, do you know where the `crypto` commit hash bump came from? Was that a manual change you did? I found that hash on the `master` branch, so I don't have a problem with using it (I see the current commit we're using is pretty old). {{{ diff --git a/projects/goxcrypto/config b/projects/goxcrypto/config index 698f94b1..83e3e7fe 100644 --- a/projects/goxcrypto/config +++ b/projects/goxcrypto/config @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 version: '[% c("abbrev") %]' git_url: https://go.googlesource.com/crypto -git_hash: ff983b9c42bc9fbf91556e191cc8efb585c16908 +git_hash: e7c4368fe9ddd156b5f1463283cb51c5b400c373 filename: '[% project %]-[% c("version") %]-[% c("var/osname") %]-[% c("var/build_id") %].tar.gz' build: '[% c("projects/go/var/build_go_lib") %]' }}} -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33576#comment:10> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs