#33626: Add TBB project for GeckoView
-------------------------------------------------+-------------------------
Reporter: sisbell | Owner: gk
Type: task | Status:
| needs_review
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, tbb-rbm, | Actual Points:
TorBrowserTeam202005R, GeorgKoppen202005 |
Parent ID: #33184 | Points:
Reviewer: sysrqb | Sponsor:
| Sponsor58-must
-------------------------------------------------+-------------------------
Comment (by boklm):
Replying to [comment:12 boklm]:
> Replying to [comment:10 gk]:
> > `bug_33626_v6` (https://gitweb.torproject.org/user/gk/tor-browser-
build.git/commit/?h=bug_33626_v6&id=288efe34fbcdbc8ea69184585646440c89f5b2d1)
contains a patch for review.
> >
> > Ideally I'd like to have the `get-moz-build-date` either in the
`commons` project and then refer to that from the `firefox` and
`geckoview` config file or, less ideally, just have a symlink in
`geckoview` pointing to the script in `firefox`. I got neither of that to
work. Maybe boklm has an idea about how to do that.
>
> What happens when you do a symlink `projects/geckoview/get-moz-build-
date -> projects/firefox/get-moz-build-date`?
After checking, it seems we copy symlinks as symlinks to the container, so
this is probably why it doesn't work. But this is what we want for
`projects/tor-browser/Bundle-Data/mac-applications.dmg/Applications`.
Maybe we could add an option to rbm to select whether de-reference
symlinks while copying a file from `input_files`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33626#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
