#33812: Add unit tests for bandwidth statistics functions -------------------------------------------+------------------------------- Reporter: MrSquanchee | Owner: MrSquanchee Type: task | Status: needs_review Priority: Medium | Milestone: Tor: | unspecified Component: Core Tor/Tor | Version: Severity: Minor | Resolution: Keywords: prop313, ipv6, outreachy-ipv6 | Actual Points: Parent ID: #33617 | Points: 2 Reviewer: ahf | Sponsor: Sponsor55-can -------------------------------------------+------------------------------- Changes (by MrSquanchee):
* status: needs_revision => needs_review Comment: Replying to [comment:11 ahf]: > Sorry for the slow response here. I think the patches looks very good and I was only able to find a few smaller nitpicks in the code. > > I think this is a big step in the right direction for this code. Thanks, I moved out all of the function declarations from bw_array_st.h to bw_array.h. And changed add_obs function to inline. Reviewer changes implemented : https://github.com/torproject/tor/pull/1853 -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33812#comment:12> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs