#31278: Chrome proxies hang with open idle connection
-------------------------------------+-----------------------------
Reporter: cypherpunks | Owner: (none)
Type: defect | Status: merge_ready
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: snowflake-webextension | Actual Points:
Parent ID: | Points: 2
Reviewer: dcf | Sponsor:
-------------------------------------+-----------------------------
Changes (by dcf):
* status: needs_review => merge_ready
Comment:
Looks okay. I would suggest `false` for the default value of
`messageTimer` rather than `0`, because it's more obviously false in an
`if` statement and less likely to be confused with a count of
milliseconds. I would also increase `messageTimeout` by 5 seconds or so,
so it's well above `SnowflakeTimeout` in the client--just so that the
sequence of events is deterministic and we don't have the client and proxy
racing to close the connection with equal timeouts.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31278#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
