#33973: Create fat .aar for geckoview -------------------------------------------------+------------------------- Reporter: gk | Owner: gk Type: task | Status: | needs_review Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-mobile, tbb-rbm, | Actual Points: TorBrowserTeam202005R, GeorgKoppen202005 | Parent ID: #33184 | Points: Reviewer: sysrqb | Sponsor: -------------------------------------------------+------------------------- Changes (by gk):
* keywords: tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005 * status: needs_revision => needs_review Comment: Replying to [comment:27 ahf]: > I have managed to build this branch now on two different machines. > > The only changes I have had to make so far are: > > {{{ > diff --git a/README b/README > index 8e97e2f..2457f15 100644 > --- a/README > +++ b/README > @@ -198,7 +198,7 @@ builds, and will require that you run Debian Stretch and install build > dependencies for all the components that are built. This can be done > with the following command: > > - # apt-get install build-essential python automake libtool zip unzip > + # apt-get install build-essential python automake libtool zip unzip \ > autoconf2.13 openjdk-8-jdk gettext-base autotools-dev \ > automake autoconf libtool autopoint libssl-dev \ > pkg-config zlib1g-dev libparallel-forkmanager-perl \ > diff --git a/projects/geckoview/config b/projects/geckoview/config > index 63da289..ddab204 100644 > --- a/projects/geckoview/config > +++ b/projects/geckoview/config > @@ -93,6 +93,7 @@ steps: > > input_files: > - project: container-image > + pkg_type: build > - name: '[% c("var/compiler") %]' > project: '[% c("var/compiler") %]' > pkg_type: build > }}} > > Where the last part was from boklm and GeKo on IRC. Thanks. The first part is addressed in #34247 and for the other one I pushed a fixup commit to `bug_33973_v7` (commit `3a24048253dd5f4fe79c0d44e3aff9f0fdb81d92`). `bug_33973_v8` (https://gitweb.torproject.org/user/gk/tor-browser- build.git/commit/?h=bug_33973_v8&id=544853e0c7c8adb58fb36a4582244a00f72a5838) has the fixed up commit rebased on latest `master` and the updated branch for #33626 (`bug_33626_v11`). > From what I can tell with the code is that it seems reasonable. I am not sure what the common strategy is for when you review build-system components in the browser. In Tor we have all kinds of sanitizers from shellcheck that we run on shell-like scripts. The code looks fine to me, is easy to understand once the gist of rbm kicks in. There are no sanitizers for `tor-browser-build` changes (yet). It's "just" code change review and testing that the proposed changes actually work. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33973#comment:29> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs