#33558: Update TOPL To Use Updated Android Toolchain -------------------------------------------------+------------------------- Reporter: sisbell | Owner: gk Type: defect | Status: | needs_review Priority: High | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-mobile, tbb-rbm, | Actual Points: .5 GeorgKoppen202005, TorBrowserTeam202005R | Parent ID: #33184 | Points: Reviewer: sysrqb, ahf | Sponsor: | Sponsor58-must -------------------------------------------------+-------------------------
Comment (by gk): Replying to [comment:12 gk]: > One thing I still need to think about is: > {{{ > There are some combinations of libraries, or tools and libraries, that are incompatible, or can lead to bugs. One such incompatibility is compiling with a version of the Android support libraries that is not the latest version (or in particular, a version lower than your targetSdkVersion). > }}} > (found at: https://stackoverflow.com/questions/53094716/implementation- com-android-supportappcompat-v728-0-0) > > We do set the `targetSdkVersion` to `29` while we have > {{{ > dependencies { > implementation project(':universal') > implementation 'net.freehaven.tor.control:jtorctl:0.2' > implementation 'org.slf4j:slf4j-api:1.7.25' > implementation 'org.slf4j:slf4j-android:1.7.25' > implementation 'com.android.support:appcompat-v7:28.0.0' > testImplementation 'junit:junit:4.12' > androidTestImplementation project(':android_tor_installer') > androidTestImplementation 'org.torproject:tor-android- binary:0.3.5.8-rc-v2' > androidTestImplementation 'com.android.support.test:runner:1.0.1' > androidTestImplementation 'com.android.support.test.espresso :espresso-core:3.0.1' > } > }}} > I wonder whether that's indeed as problematic for us as the quote suggests... As a data point: Mozilla seems to be on 28.0.0 for the support library while targeting Android 29. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33558#comment:13> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs