#15197: Rebase Tor Browser patches to ESR 45 -------------------------------------------------+------------------------- Reporter: gk | Owner: Type: task | arthuredelstein Priority: Very High | Status: Component: Tor Browser | needs_revision Severity: Critical | Milestone: Keywords: ff45-esr, TorBrowserTeam201604, | Version: tbb-6.0a5 | Resolution: Parent ID: | Actual Points: Reviewer: | Points: | Sponsor: | SponsorU -------------------------------------------------+-------------------------
Comment (by arthuredelstein): Replying to [comment:23 mcs]: > Kathy and I are part way through our review of the brade/mcs patches. Here is what we found so far: Thank you for looking at these. > For #14716 (f66d0f7d06baba14e97bf63e5b2e0fbd5674c62d), it looks like {{{throw "string"}}} was replaced with {{{throw new Error("string")}}} throughout nsLoginManager.js, so we should probably do the same for the two throw statements that we add. Fixed. > For #6786 (upstreamed), part of our original patch was dropped. See https://bugzilla.mozilla.org/show_bug.cgi?id=232227#c42 Is there another Bugzilla bug for this? I think we want the missing part in Tor Browser. I hadn't realized this. I'm opening a ticket to bring this back the dropped piece: #18777. The new branch will be in the next comment. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15197#comment:40> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs