#16698: Split directory_handle_command_get into per-command functions -------------------------------------------------+------------------------- Reporter: nickm | Owner: nickm Type: defect | Status: Priority: Medium | merge_ready Component: Core Tor/Tor | Milestone: Tor: Severity: Normal | 0.2.9.x-final Keywords: 028-triaged, tor-tests-coverage, | Version: tor-tests-unit, TorCoreTeam201605, review- | Resolution: group-1 | Actual Points: Parent ID: | Points: Reviewer: dgoulet | small/medium | Sponsor: | SponsorS-can -------------------------------------------------+------------------------- Changes (by dgoulet):
* status: needs_review => merge_ready Comment: * Comment says the follow for `directory_handle_command_get()` but we do return 404 at the end if unrecognized (`/* we didn't recognize the url */`). I'm guessing this is just a comment issue here. {{{ * ... If the request is unrecognized, send a 400. * Always return 0. */ }}} Putting this in `merge_ready` because the above is easy to fix thus falls under nickm. rest lgtm! (and I'm happpppppyyyy about that change :) -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16698#comment:15> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs