#18616: Relay fails to self-test its DirPort with AccountingMax enabled -------------------------------------------------+------------------------- Reporter: toralf | Owner: andrea Type: defect | Status: Priority: Medium | needs_review Component: Core Tor/Tor | Milestone: Tor: Severity: Normal | 0.2.8.x-final Keywords: regression, must-fix-before-028-rc, | Version: Tor: TorCoreTeam201605, TorCoreTeam- | 0.2.8.1-alpha postponed-201604, review-group-1 | Resolution: Parent ID: | Actual Points: 20 Reviewer: arma | hours | Points: medium | Sponsor: -------------------------------------------------+-------------------------
Comment (by teor): Replying to [comment:31 arma]: > Ok, I looked at {{{bug18616-v3-squashed}}}. Looks good to me. > > I have a further cleanup patch on my side that I'm still working on. But I realized I'm confused about what's actually being fixed here. > > Here's my in-progress new changes file: > {{{ > o Major bugfixes (directory mirrors): > - Fix broken DirPort self-checks. Decide to advertise begindir > support the same way we decide to advertise DirPorts. > Resolves bug 18616; bugfix on 0.2.8.1-alpha. Patch by teor. > > o Minor bugfixes: > - Add additional config options that might change the content of > a relay's descriptor. Fixes more of bug 12538; bugfix on 0.2.8.1-alpha. > - Avoid checking ORPort reachability when the network is disabled. > }}} > > For the first entry, what exactly was broken about them? I think that's this ticket. What was the actual bug? DirPort self-checks were failing with error messages. They also weren't being scheduled and checked correctly. We fixed some of it in #18632, this is the cleanup / remainder. > > And then for the last entry, was that something that could happen to users in practice? Yes, if they did a HUP after changing any of those options, it would be 18 hours before they were reflected in the descriptor. This would be a problem if they added a quota and wanted the DirPort to stop working soon. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18616#comment:32> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs