On Thu, Apr 26, 2012 at 4:37 PM, Esteban Manchado Velázquez <[email protected]> wrote: > On Thu, 26 Apr 2012 09:09:09 +0200, Gisle Vanem <[email protected]> wrote: > >> The src/test/test_util.c doesn't compile with MSVC (CL ver. >> 16.00.30319.01). >> It doesn't like the "#ifdef 0" construct, but the whole chunk should be >> enabled with some modifications IMHO. > > > Ugh, sorry about that. I made the changes blindly because I didn't have > any way to test them on Windows :-S > > >> 'path_is_relative()' doesn't handle the "http:\\dir" case though. Why >> should it? Besides 'expand_filename()' isn't for Windows. I suggest this >> patch: > > > Looking at the tests now, if we leave "http:\\dir" around it should > probably return 1 (it's as nonsensical as "dir\\a:" so it should behave the > same). It's probably not useful, so we can drop it... but in case of leaving > it around, it should be moved right after "dir\\a:\\" (ie. at the end of the > cases that return 1).
Thanks! I actually ran into the same issues today while I was experimenting with cross-compiling from fedora 16. I checked in this fix, and some unrelated cross-compilation issues, as 9dddfe83f3041e1504d2def5. yrs, -- Nick _______________________________________________ tor-dev mailing list [email protected] https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
