On Mon, 08 Aug 2016, nusenu wrote: > >> When upgrading, all running tor instances are stopped (not restarted, as > >> expected) > > > > This might be your root-cause as well? > > > > https://github.com/nusenu/ansible-relayor/issues/72 > > > > I'm generating instance names based on IP addresses_ORport (so they > > contain "." and "_") and are therefore filtered by the generator. > > > > Is it acceptable to add "." and "_" to the whitelist? > > > > (patches attached) > > Based on the output of 'systemd-escape' (a tool that escapes strings for > use in unit names) it is safe to use "." and "_" in unit names.
I am always wary of allowing dots in anything. Allowing dots and thereby also allowing ".." is the origin of many vectors. This doesn't necessarily mean that it's a problem here, but it's the reason I usually exclude periods from. Another is that I want to be able to move foo to foo.disabled or foo.bak, and have it not get picked up. I could see adding underscores and hyphens, to match run-parts. -- | .''`. ** Debian ** Peter Palfrader | : :' : The universal https://www.palfrader.org/ | `. `' Operating System | `- https://www.debian.org/ _______________________________________________ tor-relays mailing list tor-relays@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays