Daniel Rall <[EMAIL PROTECTED]> writes:
-1 on this change.
I'd prefer to get the contract changed so that "null" is a legal value.
We discussed this in length, it would've been nice if you had read the
archives before simply changing this to an exception
Regards
Henning
>[EMAIL PROTECTED] writes:
>...
>> 1.9 +18 -9 db-torque/src/java/org/apache/torque/util/Transaction.java
>>
>> Index: Transaction.java
>> ===================================================================
>> RCS file: /home/cvs/db-torque/src/java/org/apache/torque/util/Transaction.java,v
>> retrieving revision 1.8
>> retrieving revision 1.9
>> diff -u -r1.8 -r1.9
>> --- Transaction.java 18 May 2003 12:27:24 -0000 1.8
>> +++ Transaction.java 3 Aug 2003 17:41:04 -0000 1.9
>> @@ -182,7 +182,7 @@
>> {
>> if (con == null)
>> {
>> - log.error("Connection object was null. "
>> + throw new TorqueException("Connection object was null. "
>> + "This could be due to a misconfiguration of the "
>> + "DataSourceFactory. Check the logs and Torque.properties "
>> + "to better determine the cause.");
>IllegalArgumentException might make more sense here.
>--
>Daniel Rall
>---------------------------------------------------------------------
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED] +49 9131 50 654 0 http://www.intermeta.de/
Java, perl, Solaris, Linux, xSP Consulting, Web Services
freelance consultant -- Jakarta Turbine Development -- hero for hire
"Dominate!! Dominate!! Eat your young and aggregate! I have grotty silicon!"
-- AOL CD when played backwards (User Friendly - 200-10-15)
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
