Thomas Fischer wrote:
Thomas,
Although I'm +1 on the solution for customizable adapters, the
implementation could be slightly improved in my eyes. The method
DBFactory.create(String) throws an exception in the case where a custom
DB adapter is used. I am in favour of not throwing exceptions if a legal
condition occurs, so I'd rather return null in the method. I can do it
if you do not mind.
I guess this is a matter of taste. I do not consider exceptions to be
"evil" actually. Feel free to change it.
Would you also mind to add some documentation to the
initialisation-configuration.xml in the runtime reference ? This is
where (hopefully) all runtime configuration settings should be explained.
I added some stuff to the new-database-support.xml as you probably
noticed. You can re-use that if you like.
Bye, Thomas.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
