Yes, you're right.. I'll get around to doing this (may be a while since my life's a little hectic right now).
FWIW, I did it this way because I was trying to get this included with 3.3 and wanted a minimum impact on any existing classes...lol > -----Original Message----- > From: Thomas Vandahl [mailto:[EMAIL PROTECTED] > Sent: Wednesday, April 02, 2008 3:13 AM > To: Apache Torque Developers List > Subject: Re: svn commit: r643209 - in /db/torque: > runtime/trunk/src/java/org/apache/torque/adapter/ > runtime/trunk/src/java/org/apache/torque/util/ > runtime/trunk/src/java/org/apache/torque/util/functions/ > test/trunk/test-project/src/java/org/apache/torque/util/ tes > > [EMAIL PROTECTED] wrote: > > + * Initialize the functionClasses lookup table with SQL99 > standard > > + * functions. Uses this method because DB implementations don't > > + * currently call super() in their constructors and we want this > > + * to be set in all of them. > > I consider class block initializers a code smell. We already got hurt > by > them in the Peer classes where they inhibit a correct lifecycle for the > MapBuilders. Why don't you simply add the super()-call to the adapters? > There are only a few of them so this should take less than five > minutes. > > Bye, Thomas. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] DukeCE Privacy Statement: Please be advised that this e-mail and any files transmitted with it are confidential communication or may otherwise be privileged or confidential and are intended solely for the individual or entity to whom they are addressed. If you are not the intended recipient you may not rely on the contents of this email or any attachments, and we ask that you please not read, copy or retransmit this communication, but reply to the sender and destroy the email, its contents, and all copies thereof immediately. Any unauthorized dissemination, distribution or copying of this communication is strictly prohibited. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
