Author: tfischer
Date: Sun Dec 11 19:08:28 2011
New Revision: 1213042
URL: http://svn.apache.org/viewvc?rev=1213042&view=rev
Log:
Fix some PMD bugs
Modified:
db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/util/functions/FunctionFactory.java
Modified:
db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/util/functions/FunctionFactory.java
URL:
http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/util/functions/FunctionFactory.java?rev=1213042&r1=1213041&r2=1213042&view=diff
==============================================================================
---
db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/util/functions/FunctionFactory.java
(original)
+++
db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/util/functions/FunctionFactory.java
Sun Dec 11 19:08:28 2011
@@ -65,8 +65,10 @@ public final class FunctionFactory
boolean distinct)
throws Exception
{
- return functionInstance(dbName, FunctionEnum.AVG,
- new Object[]{column, new Boolean(distinct)});
+ return functionInstance(
+ dbName,
+ FunctionEnum.AVG,
+ new Object[]{column, Boolean.valueOf(distinct)});
}
/**
* Convenience method for creating a non-distinct function that uses
@@ -98,8 +100,10 @@ public final class FunctionFactory
boolean distinct)
throws Exception
{
- return functionInstance(dbName, FunctionEnum.COUNT,
- new Object[]{column, new Boolean(distinct)});
+ return functionInstance(
+ dbName,
+ FunctionEnum.COUNT,
+ new Object[]{column, Boolean.valueOf(distinct)});
}
/**
* Convenience method for creating a non-distinct function that uses
@@ -131,8 +135,10 @@ public final class FunctionFactory
boolean distinct)
throws Exception
{
- return functionInstance(dbName, FunctionEnum.MAX,
- new Object[]{column, new Boolean(distinct)});
+ return functionInstance(
+ dbName,
+ FunctionEnum.MAX,
+ new Object[]{column, Boolean.valueOf(distinct)});
}
/**
* Convenience method for creating a non-distinct function that uses
@@ -164,8 +170,10 @@ public final class FunctionFactory
boolean distinct)
throws Exception
{
- return functionInstance(dbName, FunctionEnum.MIN,
- new Object[]{column, new Boolean(distinct)});
+ return functionInstance(
+ dbName,
+ FunctionEnum.MIN,
+ new Object[]{column, Boolean.valueOf(distinct)});
}
/**
* Convenience method for creating a non-distinct function that uses
@@ -197,8 +205,10 @@ public final class FunctionFactory
boolean distinct)
throws Exception
{
- return functionInstance(dbName, FunctionEnum.SUM,
- new Object[]{column, new Boolean(distinct)});
+ return functionInstance(
+ dbName,
+ FunctionEnum.SUM,
+ new Object[]{column, Boolean.valueOf(distinct)});
}
/**
* Convenience method for creating a non-distinct function that uses
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]