[
https://issues.apache.org/jira/browse/TORQUE-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176057#comment-13176057
]
Thomas Fox commented on TORQUE-178:
-----------------------------------
As discussed in the mailing list, the old behaviour should be unchanged but the
old util.Criteria object should keep its old behaviour but become deprecated.
The old class will be removed in Torque 4.1.
A new package org.apache.torque.criteria should be created. A new Criteria
class should be created therein which has the new behaviour.
> Change semantics of add() and or() methods in Criteria
> ------------------------------------------------------
>
> Key: TORQUE-178
> URL: https://issues.apache.org/jira/browse/TORQUE-178
> Project: Torque
> Issue Type: Improvement
> Components: Runtime, Templates
> Reporter: Thomas Fox
> Assignee: Thomas Fox
> Fix For: 4.0
>
>
> In my opinion, the Criteria.add() and Criteria.or() method behave
> counter-intuitively. My opinion of an intuitive behaviour would be:
> - Criteria.or(someCondition) should result in a where clause which contains
> ((whatever was in the where condition before) OR someCondition)
> - Criteria.add(someCondition) should result in a where clause which contains
> ((whatever was in the where condition before) AND someCondition), i.e. the
> same as Criteria.and(someCondition)
> Instead, the behaviour is now
> - Criteria.or(someCondition) only or's the new condition with any existing
> condition(s) that affects the same column.
> - Criteria.add(someCondition) replaces any existing condition(s) that affects
> the same column with the new condition.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscr...@db.apache.org
For additional commands, e-mail: torque-dev-h...@db.apache.org
