Author: tfischer
Date: Mon Aug 27 02:58:08 2012
New Revision: 1377556
URL: http://svn.apache.org/viewvc?rev=1377556&view=rev
Log:
added some Findbugs exclusions for runtime
Modified:
db/torque/torque4/trunk/torque-runtime/src/main/plugin-config/findbugs-exclude.xml
Modified:
db/torque/torque4/trunk/torque-runtime/src/main/plugin-config/findbugs-exclude.xml
URL:
http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-runtime/src/main/plugin-config/findbugs-exclude.xml?rev=1377556&r1=1377555&r2=1377556&view=diff
==============================================================================
---
db/torque/torque4/trunk/torque-runtime/src/main/plugin-config/findbugs-exclude.xml
(original)
+++
db/torque/torque4/trunk/torque-runtime/src/main/plugin-config/findbugs-exclude.xml
Mon Aug 27 02:58:08 2012
@@ -19,4 +19,58 @@
-->
<FindBugsFilter>
+ <Match>
+ <!--
+ Findbugs is complaining that access to the field "managers"
+ is inconsistently synchronized.
+ From code reading this seems ok, only writes are synchronized.
+ -->
+ <Class name="org.apache.torque.TorqueInstance" />
+ <Bug pattern="IS2_INCONSISTENT_SYNC" />
+ </Match>
+ <Match>
+ <!--
+ Criterion may hold a reference to an array which is modifiable from
+ outside.
+ This does not seem to be problematic if the array only lives in
+ one thread.
+ -->
+ <Class name="org.apache.torque.criteria.Criterion" />
+ <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2" />
+ </Match>
+ <Match>
+ <!--
+ ComboKey may hold a reference to an array which is modifiable from
+ outside.
+ This does not seem to be problematic if the array only lives in
+ one thread.
+ -->
+ <Class name="org.apache.torque.om.ComboKey" />
+ <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2" />
+ </Match>
+ <Match>
+ <!--
+ WhereClauseExpression may hold a reference to an array
+ which is modifiable from outside.
+ This does not seem to be problematic if the array only lives in
+ one thread.
+ -->
+ <Class name="org.apache.torque.sql.WhereClauseExpression" />
+ <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2" />
+ </Match>
+ <Match>
+ <!--
+ It is ok that BasePeerImpl generates SQL statements
+ from nonconstant strings.
+ -->
+ <Class name="org.apache.torque.util.BasePeerImpl" />
+ <Bug pattern="SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING" />
+ </Match>
+ <Match>
+ <!--
+ Do not report improvements for old Criteria.Criterion class
+ -->
+ <Class name="org.apache.torque.util.Criteria$Criterion" />
+ <Bug pattern=" SE_INNER_CLASS,SIC_INNER_SHOULD_BE_STATIC" />
+ </Match>
</FindBugsFilter>
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
