Author: tfischer
Date: Sun Jan 27 20:59:32 2013
New Revision: 1439177
URL: http://svn.apache.org/viewvc?rev=1439177&view=rev
Log:
TORQUE-260: remove size for binary datatype in mssql
Do not allow setting size for text and image data types.
Added:
db/torque/torque4/trunk/torque-templates/todo.txt
Modified:
db/torque/torque4/trunk/torque-templates/src/main/java/org/apache/torque/templates/platform/PlatformMssqlImpl.java
Modified:
db/torque/torque4/trunk/torque-templates/src/main/java/org/apache/torque/templates/platform/PlatformMssqlImpl.java
URL:
http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-templates/src/main/java/org/apache/torque/templates/platform/PlatformMssqlImpl.java?rev=1439177&r1=1439176&r2=1439177&view=diff
==============================================================================
---
db/torque/torque4/trunk/torque-templates/src/main/java/org/apache/torque/templates/platform/PlatformMssqlImpl.java
(original)
+++
db/torque/torque4/trunk/torque-templates/src/main/java/org/apache/torque/templates/platform/PlatformMssqlImpl.java
Sun Jan 27 20:59:32 2013
@@ -75,7 +75,7 @@ public class PlatformMssqlImpl extends P
new SqlType("DATETIME"));
setSchemaTypeToSqlTypeMapping(
SchemaType.BINARY,
- new SqlType("BINARY(7132)"));
+ new SqlType("BINARY"));
setSchemaTypeToSqlTypeMapping(
SchemaType.VARBINARY,
new SqlType("IMAGE"));
@@ -128,4 +128,13 @@ public class PlatformMssqlImpl extends P
{
return true;
}
+
+ /**
+ * @see Platform#hasSize(String)
+ */
+ @Override
+ public boolean hasSize(String sqlType)
+ {
+ return !("IMAGE".equals(sqlType) || "TEXT".equals(sqlType));
+ }
}
Added: db/torque/torque4/trunk/torque-templates/todo.txt
URL:
http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-templates/todo.txt?rev=1439177&view=auto
==============================================================================
--- db/torque/torque4/trunk/torque-templates/todo.txt (added)
+++ db/torque/torque4/trunk/torque-templates/todo.txt Sun Jan 27 20:59:32 2013
@@ -0,0 +1,47 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+- check values of the sqlDataType (custom platform docs !)
+- in the file
org/apache/torque/templates/transformer/om/OMTableTransformer.properties
+ rename the option torque.om.package.package to torque.om.package
+ and also in docs
+
+- remove the getOMClass() method, the CLASS_DEFAULT constant and the
initClass()
+ method in the peer templates.
+
+ - remove the throws TorqueException in places where no database access
+ and no potential configuration problem occurs ?
+
+- return the number of deleted objects in doDelete methods
+- rename numColumns constant ?
+- what to do with unused field cascade in criteria ?
+- autocommit handling in Transaction: connections are set autocommit after
releasing. Why ?
+- useTransaction field in Criteria. What is its use ? Remove ?
+- Joins are not serializable. Why? also check readObject and writeObject
methods in Criteria
+
+
+in om classes:
+- getPeer() method. Should this now return peerImpl or be removed completely ?
+
+in peer classes:
+- remove deprecated getMapBuilder() methods ?
+
+- find warnings in generation process (undefined mergepoints ?)
+
+- use "XXX char" as Varchar size for Oracle scripts
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
