[ https://issues.apache.org/jira/browse/TORQUE-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099339#comment-14099339 ]
Thomas Fox commented on TORQUE-320: ----------------------------------- Thomas, would an acceptable solution be having a second method Criteria.addGroupByColumn(final Column groupBy, final boolean addColumToSelectColumns) so users can decide whether to explicitly add the group by column to the select columns? If yes, the other question is whether we should change the default behaviour of Criteria.addGroupByColumn(final Column groupBy) to not adding the select columns. In my opinion yes, because that is what one would expect from just looking at the API > GroupBy adds columns to the select clause > ----------------------------------------- > > Key: TORQUE-320 > URL: https://issues.apache.org/jira/browse/TORQUE-320 > Project: Torque > Issue Type: Bug > Components: Runtime > Affects Versions: 4.0 > Reporter: Thomas Fox > > If I create a Criteria, define the select columns manually and then add > groupBy Columns, SqlBuilder adds the groupBy Columns to the select columns > One should be able to create GROUP BY Queries without adding the columns to > the select clause -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscr...@db.apache.org For additional commands, e-mail: torque-dev-h...@db.apache.org