[ 
https://issues.apache.org/jira/browse/TORQUE-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970604#comment-14970604
 ] 

Thomas Fox commented on TORQUE-108:
-----------------------------------

If you want, can you provide your test so it can be added to the torte test 
suite ? Please reopen the ticket if you do so.
As for the ColumnImpl, the reason why this was introdiced is that if you do 
criteria.add("test","value") there is no way of telling whteher "test" and 
"value" are table columns or verbatim values. ColumnImpl provides a clean 
distiction: all ColumnImpl objects are columns, and all String fields are 
verbatim values.

> Criteria addJoin causes incorrect SQL to be generated when optional schema 
> references are in use (Oracle)
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: TORQUE-108
>                 URL: https://issues.apache.org/jira/browse/TORQUE-108
>             Project: Torque
>          Issue Type: Bug
>          Components: Runtime
>    Affects Versions: 3.3-RC1, 3.3-RC2, 3.3-RC3
>         Environment: Linux, Java 1.6
>            Reporter: Brendan Miller
>            Assignee: Thomas Fox
>             Fix For: 4.0-beta1
>
>         Attachments: JoinBuilderTest.java, joinbuilder.patch
>
>
> I previously wrote about this to torque-user in Oct 2007.
> In a schema definition that includes torque.dsfactory.programs.schema, 
> writing the following
> Criteria crit = new Criteria();
> crit.addJoin(TransactionPeer.ORDER_ID, OrderPeer.ID);
> crit.add(TransactionPeer.ACCT_ID, account.getID());
> List<Order> orders = OrderPeer.doSelect(crit);
> generates
> SELECT <..ORDERS columns..> FROM TRANSACTION, ORDERS, DBSCHEMA.ORDERS, 
> DBSCHEMA.TRANSACTION
> WHERE TRANSACTION.ORDER_ID=ORDERS.ID AND TRANSACTION.ACCT_ID= ?
> Upon examining the Torque code, it appears that SQLBuilder.processJoins does 
> not add the full table names, while SQLBuilder.processCriterions does.
> Shouldn't they both add the full table names?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscr...@db.apache.org
For additional commands, e-mail: torque-dev-h...@db.apache.org

Reply via email to