Hi Georg, Yes - I wasn't sure if testcontainer 1.0.8 had fully propagated through the repositories yet. I was going to do it today, but you beat me to it :-)
I did update all of turbine & fulcrum components yesterday though with the release version. Thanks for taking a look at this and helping make the updates to the test cases! I have success on my end now as well :-) I was just trying to make sure everything that depended on testcontainer and yaafi were still working OK with the new releases. Thank you! Environment: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: /usr/java/maven Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: /usr/java/jdk1.8.0_191/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.15.0-43-generic", arch: "amd64", family: "unix" - Jeff On 1/8/19 2:45 AM, Georg Kallidis wrote: > Hi Jeffery, > > did you spot that it's still a SNAPSHOT version for fulcrum-testcontainer > in pom.xml? > > I removed this part as well as all the jupiter dependencies, except junit > 4.12 as it is referenced in child poms (this might be also removed) and > the tests run without failures! > > Environment: > > Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; > 2018-02-24T20:49:05+01:00) > Java version: 1.8.0_171, vendor: Oracle Corporation > Default locale: de_DE, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" > > Best regards, Georg > > > > Von: Jeffery Painter <j...@jivecast.com> > An: d...@turbine.apache.org, torque-dev@db.apache.org > Datum: 07.01.2019 17:02 > Betreff: Re: Updating Torque to testframework 1.0.8 > > > > I think I have it figured out... as soon as I verify all is building > correctly, I will commit the changes to torque SVN. > > It looks like the torque/pom.xml needed some of the extra jupiter config > added in that you had put in the turbine pom that I had missed. > > Thanks! > Jeff > > On 1/7/19 10:47 AM, Georg Kallidis wrote: >> Hi Jeffery, >> >> no, I haven't seen this. But what happens, if you provide a Test >> annotation for testPrintStackTrace? >> >> You might want to check in all except this test class ( >> TorqueRuntimeExceptionTest), but actually it's only a warning. >> >> What do you think? You might also provide a patch straightforward, where >> we could work on.. >> >> Best regards, Georg >> >> >> >> >> Von: Jeffery Painter <j...@jivecast.com> >> An: torque-dev@db.apache.org, Georg Kallidis >> <georg.kalli...@cedis.fu-berlin.de>, Turbine Developers List >> <d...@turbine.apache.org> >> Datum: 07.01.2019 15:32 >> Betreff: Updating Torque to testframework 1.0.8 >> >> >> >> Hi guys, >> >> I have made most of the modifications to torque 4.1-SNAPSHOT to support >> using testframework 1.0.8 (I had forgotten to update the maven surefire >> plugin)... in the process, I was also updating a bunch of the test code >> to look more like the way the test cases have been updated for turbine >> (using proper @Test annotations, etc) >> >> However, I am coming across one issue I haven't been able to figure >> out. All the tests now run again and pass, but I am getting a weird >> message from the vintage method on finding the unique ID for each test >> case. Georg, did you run into this before? Do you know how to resolve >> it? My google searches aren't coming up with much. The one thing I >> found said replace all references to Assert methods with static imports, >> and I went through all of that already (a pain, but done)... I don't >> want to check anything else in without trying to resolve this issue >> first :-) >> >> See this link which is reporting the same issue I am having: >> >> > https://www.reddit.com/r/javahelp/comments/5gtjba/junit_5_test_suite_on_intellij_tests_run_work_but/ > >> >> >> Let me know if you have seen it, know a way to fix it - we don't see >> these errors on the Turbine side. >> >> Example of the warning message: >> >> [INFO] Running ColumnImplTest >> [INFO] Tests run: 41, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: >> 0.096 s - in ColumnImplTest >> Jan 07, 2019 9:26:28 AM org.junit.vintage.engine.support.UniqueIdReader >> lambda$apply$1 >> WARNING: Could not read unique ID for Description; using display name >> instead: > testPrintStackTrace(org.apache.torque.TorqueRuntimeExceptionTest) >> [INFO] Running TorqueRuntimeExceptionTest >> >> >> And the good news :-) >> >> >> [INFO] Running ColumnMapTest >> [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: >> 0.05 s - in ColumnMapTest >> [INFO] >> [INFO] Results: >> [INFO] >> [INFO] Tests run: 232, Failures: 0, Errors: 0, Skipped: 0 >> [INFO] >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] BUILD SUCCESS >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] Total time: 28.653 s >> [INFO] Finished at: 2019-01-07T09:26:40-05:00 >> [INFO] >> ------------------------------------------------------------------------ >> >> >> >> >> Thanks! >> Jeff Painter >> >> >> >> [Anhang "signature.asc" gelöscht von Georg Kallidis/CeDiS/FU-Berlin/DE] >> > > [Anhang "signature.asc" gelöscht von Georg Kallidis/CeDiS/FU-Berlin/DE] > --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscr...@db.apache.org For additional commands, e-mail: torque-dev-h...@db.apache.org
