Hi Jeffery, ok, I missed this. I tested only with local mysql 10.1.36-MariaDB and the test passed (!). And it is not included in the mysql docker tests in package org.apache.torque.testcontainer. If I test it with mysql image mysql:8.0.18 the test fails. I get this error: org.junit.ComparisonFailure: expected:<1970-01-01 1[2]:21:31> but was:<1970-01-01 1[1]:21:31> "Expected" is this code: toString(doSelect(toDate("1970-01-01 11:21:31"), java.sql.Time.class, adapter))
It seems to me, that this may be converted from GMT to system default time zone (for me: as summertime is only after 1996 it is Europe/Berlin / CET, which has a one hour difference from GMT -> 12 instead of 11, in your case about GMT - 6h). If I add the timezone in the jdbc driver in org.apache.torque.testcontainer.junit5.extension.DockerCallbackMySQLExtension call of generateJdbcUrl("?loggerLevel=OFF&serverTimezone="+ ZoneId.systemDefault ()); the test passes (!) But why do date and timestamp tests pass? This is how docker mysql (TODO postgresql docker) could be fixed, but what if running a mysql server locally? Best regards, Georg P.S.: We set in pom.xml the jdbc in profile mysql with hard coded serverTimezone=Europe/Berlin. This has to be correct of course set and not system default. ;ay be some time zone setting is not done for time type converting. I think Thomas (tv) mentioned, that the time mapping should be reviewed once more, but he may not have done it. Von: Jeffery Painter <j...@jivecast.com> An: torque-dev@db.apache.org Datum: 03.08.2020 18:28 Betreff: Re: [VOTE] RC Torque 5.0 based on staged repository Hi Georg, Thanks for the pointer. I re-ran the tests with both PostgreSQL and MySQL. It was "managers" and not "manager" that fixed it. All looks good except for one test failure, and it looks like maybe a simple fix is needed. I get the same test failure on both databases. It looks like maybe it is a time zone issue? [ERROR] Failures: [ERROR] DefaultValuesFromDatabaseTest.testNewObjectChangedValue:211 expected:<1970-01-01 [05]:21:31> but was:<1970-01-01 [11]:21:31> [INFO] [ERROR] Tests run: 260, Failures: 1, Errors: 0, Skipped: 0 [INFO] Otherwise, I think everything looks good. - Jeffery On 8/1/20 6:17 AM, Georg Kallidis wrote: > Hi Jeffery, > > sorry, it might be, that I referred to the profile as 'manager', whereas it should be "managers". > > -Georg > > On July 31, 2020 3:30:52 PM GMT+02:00, Jeffery Painter <j...@jivecast.com> wrote: >> FYI - I get the same error when trying to run for the postgresql >> profile >> (it does create the tables): >> >> >> bookstore=# \dt >> List of relations >> Schema | Name | Type | Owner >> --------+----------------------------+-------+-------- >> public | abstract | table | torque >> public | author | table | torque >> public | autoincrement_idbroker | table | torque >> public | autoincrement_native | table | torque >> public | autoincrement_none | table | torque >> public | base | table | torque >> public | bigint_type | table | torque >> public | binary_type | table | torque >> public | bint_bchar_type | table | torque >> public | bit_composite_pk | table | torque >> public | bit_type | table | torque >> public | blob_type | table | torque >> public | book | table | torque >> >> ... >> >> >> >> On 7/31/20 9:18 AM, Jeffery Painter wrote: >>> Hi Georg, >>> >>> >>> I created a db user torque@localhost, and then ran: >>> >>> painter@merlin:~/apache/torque/torque-5.0/torque-test$ mvn clean test >>> -Pmysql,manager,beans >>> >>> The tests created lots of tables in the 'bookstore' database, but >> then I >>> got the following complaints :-( >>> >>> >>> [INFO] ------------------------------------------------------------- >>> [ERROR] COMPILATION ERROR : >>> [INFO] ------------------------------------------------------------- >>> [ERROR] >>> >> /home/painter/apache/torque/torque-5.0/torque-test/src/test/java/org/apache/torque/ManagerTestConditional.java:[31,38] >>> package org.apache.torque.test.manager does not exist >>> [ERROR] >>> >> /home/painter/apache/torque/torque-5.0/torque-test/src/test/java/org/apache/torque/ManagerTestConditional.java:[32,38] >>> package org.apache.torque.test.manager does not exist >>> [ERROR] >>> >> /home/painter/apache/torque/torque-5.0/torque-test/src/test/java/org/apache/torque/ManagerTestConditional.java:[33,38] >>> package org.apache.torque.test.manager does not exist >>> [INFO] 3 errors >>> [INFO] ------------------------------------------------------------- >>> [INFO] >>> >> ------------------------------------------------------------------------ >>> [INFO] BUILD FAILURE >>> [INFO] >>> >> ------------------------------------------------------------------------ >>> [INFO] Total time: 19.456 s >>> [INFO] Finished at: 2020-07-31T09:14:43-04:00 >>> [INFO] >>> >> ------------------------------------------------------------------------ >>> [WARNING] The requested profile "manager" could not be activated >> because >>> it does not exist. >>> [ERROR] Failed to execute goal >>> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile >>> (default-testCompile) on project torque-test: Compilation failure: >>> Compilation failure: >>> [ERROR] >>> >> /home/painter/apache/torque/torque-5.0/torque-test/src/test/java/org/apache/torque/ManagerTestConditional.java:[31,38] >>> package org.apache.torque.test.manager does not exist >>> [ERROR] >>> >> /home/painter/apache/torque/torque-5.0/torque-test/src/test/java/org/apache/torque/ManagerTestConditional.java:[32,38] >>> package org.apache.torque.test.manager does not exist >>> [ERROR] >>> >> /home/painter/apache/torque/torque-5.0/torque-test/src/test/java/org/apache/torque/ManagerTestConditional.java:[33,38] >>> package org.apache.torque.test.manager does not exist >>> [ERROR] -> [Help 1] >>> [ERROR] >>> [ERROR] To see the full stack trace of the errors, re-run Maven with >> the >>> -e switch. >>> [ERROR] Re-run Maven using the -X switch to enable full debug >> logging. >>> [ERROR] >>> [ERROR] For more information about the errors and possible solutions, >>> please read the following articles: >>> [ERROR] [Help 1] >>> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException >>> >>> >>> >>> >>>> Hi Jeffery, >>>> >>>> Hi Jeffery, >>>> >>>> thanks for voting and testing! >>>> >>>> You may also check the README in subfolder torque-test and test >> there >>>> against locale or docker databases. >>>> >>>> Best regards, >>>> >>>> Georg >>>> >>>> >>>> >>>> Von: Jeffery Painter <j...@jivecast.com> >>>> An: torque-dev@db.apache.org >>>> Datum: 30.07.2020 17:13 >>>> Betreff: Re: [VOTE] RC Torque 5.0 based on staged repository >>>> >>>> >>>> >>>> Hi Georg, >>>> >>>> I was able to check out clean from SVN and build successfully with >>>> >>>> $ mvn clean install site >>>> >>>> >>>> $ mvn -version >>>> >>>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) >>>> Maven home: /usr/java/maven >>>> Java version: 1.8.0_261, vendor: Oracle Corporation, runtime: >>>> /usr/java/jdk1.8.0_261/jre >>>> Default locale: en_US, platform encoding: UTF-8 >>>> OS name: "linux", version: "5.4.0-42-generic", arch: "amd64", >> family: >>>> "unix" >>>> >>>> >>>> The artifacts look good to me: >>>> >>>> painter@merlin:~/apache/torque/artifacts$ gpg --verify >>>> torque-5.0-source-release.zip.asc torque-5.0-source-release.zip >>>> gpg: Signature made Fri 17 Jul 2020 05:37:06 AM EDT >>>> gpg: using RSA key >> 83221A9E13D9F6A39E718DD76EAAE3D2F615E012 >>>> gpg: Good signature from "Georg Kallidis (APACHE CODE SIGNING KEY) >>>> <g...@apache.org>" [unknown] >>>> >>>> >>>> My vote >>>> >>>> [ x ] +1 release it >>>> >>>> >>>> - >>>> Jeffery Painter >>>> >>>> pain...@apache.org >>>> >>>> j...@jivecast.com >>>> >>>> >>>> >>>> On 7/17/20 6:00 AM, Georg Kallidis wrote: >>>>> Hi Torque community, >>>>> >>>>> a release candidate for Torque version 5.0 has been prepared and is >> open >>>>> for voting! >>>>> >>>>> Artifacts: >>>>> >>>>> >> https://repository.apache.org/content/repositories/orgapachetorque-1000/ >>>>> Tag: >>>>> >>>>> https://svn.apache.org/repos/asf/db/torque/torque4/tags/torque-5.0 >>>>> >>>>> This release contains the following updates: >>>>> >>>>> - 81 resolved JIRA issues: >>>>> >> https://issues.apache.org/jira/browse/TORQUE-359?jql=project%20%3D%20TORQUE%20AND%20status%20%3D%20Resolved%20AND%20fixVersion%20%3D%204.1 >>>>> (note, this is still "fix version 4.1", but will be updated to >> 5.0 >>>> later) >>>>> - a lot of bugfixes, cleanup and refactoring, e.g. >>>>> time/date/timestamp-string formatting, deprecated DBCP1 adapters, >> DBCP2 >>>> is >>>>> the default now... >>>>> - Java 8, tested and build in Java 8 and 14 with JUnit 5 and Log4j2 >>>>> - updated almost all plugin, build and database dependencies, major >>>>> updates: velocity 2.0, groovy 3.0.4 >>>>> - added Docker testcontainer profiles for mysql and postgresql >>>>> - new refactored ant task Torque4JDBCTransformTask >>>>> >>>>> Keys: >>>>> https://svn.apache.org/repos/asf/db/torque/torque4/trunk/KEYS >>>>> https://dist.apache.org/repos/dist/release/db/torque/KEYS (to be >>>> updated) >>>>> Please verify this release candidate carefully, give feedback >> or/and >>>> vote >>>>> [ ] +1 release it >>>>> [ ] +0 go ahead I don't care >>>>> [ ] -1 no, do not release it because >>>>> >>>>> >>>>> Have fun! >>>>> >>>>> >>>>> Best regards, Georg >>>>> >>>>> >> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@torque.apache.org >>>>> For additional commands, e-mail: dev-h...@torque.apache.org >>>>> >>>>> >> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: torque-dev-unsubscr...@db.apache.org >>>> For additional commands, e-mail: torque-dev-h...@db.apache.org >>>> >>>> >>>> >>>> >>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: torque-dev-unsubscr...@db.apache.org >>> For additional commands, e-mail: torque-dev-h...@db.apache.org >>> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: torque-dev-unsubscr...@db.apache.org >> For additional commands, e-mail: torque-dev-h...@db.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscr...@db.apache.org For additional commands, e-mail: torque-dev-h...@db.apache.org
smime.p7s
Description: S/MIME Cryptographic Signature