2008/4/24 TK Soh <[EMAIL PROTECTED]>:
> On Thu, Apr 24, 2008 at 4:06 AM, Steve Borho <[EMAIL PROTECTED]> wrote:
> >
> > On Thu, 2008-04-24 at 03:58 +0100, TK Soh wrote:
> > > On Thu, Apr 24, 2008 at 2:15 AM, TK Soh <[EMAIL PROTECTED]> wrote:
> > > >
> > > > On Sun, Apr 13, 2008 at 6:03 PM, Steve Borho <[EMAIL PROTECTED]>
> wrote:
> > > > >
> > > > > On Sun, 2008-04-13 at 16:09 +0100, TK Soh wrote:
> > > > > > On Thu, Apr 10, 2008 at 9:28 PM, Peer Sommerlund
> > > > > > <[EMAIL PROTECTED]> wrote:
> > > > > > > # HG changeset patch
> > > > > > > # User Peer Sommerlund <[EMAIL PROTECTED]>
> > > > > > > # Date 1207855013 -7200
> > > > > > > # Node ID d40121ae71d7bb14e239b843227c42b88f9e5635
> > > > > > > # Parent 70affe9c0fe8b574f147d135178d6292a99d8ac9
> > > > > > > overlay: Prefix registry key with "TortoiseHg"
> > > > > > >
> > > > > > > Make it easier to spot the registry keys under
> ShellIconOverlayIdentifiers
> > > > > > > that have been added by TortoiseHg, by prefixing them with
> the
> > > > > > > string "TortoiseHg".
> > > > > > >
> > > > > > > diff --git a/tortoise/iconoverlay.py
> b/tortoise/iconoverlay.py
> > > > > > > --- a/tortoise/iconoverlay.py
> > > > > > > +++ b/tortoise/iconoverlay.py
> > > > > > > @@ -256,7 +256,7 @@
> > > > > > > prog_id = "Mercurial.ShellExtension.%s" % classname
> > > > > > > desc = "Merucurial icon overlay shell extension for %s
> files" % name.lower()
> > > > > > > reg = [
> > > > > > > - (_winreg.HKEY_LOCAL_MACHINE,
> r"Software\Microsoft\Windows\CurrentVersion\Explorer\ShellIconOverlayIdentifiers\%s"
> % name) ]
> > > > > > > + (_winreg.HKEY_LOCAL_MACHINE,
> r"Software\Microsoft\Windows\CurrentVersion\Explorer\ShellIconOverlayIdentifiers\TortoiseHg%s"
> % name) ]
> > > > > > > cls = type(
> > > > > > > classname,
> > > > > > > (IconOverlayExtension, ),
> > > > > >
> > > > > > This one just came to my mind: how does the installer handle
> this
> > > > > > during upgrade, specifically on uninstalling the previous
> release?
> > > > >
> > > > > At uninstall, it unregisters the tortoisehg.dll. At upgrade,
> it just
> > > > > registers the new DLL, which I assume is essentially a NOP if
> they're in
> > > > > the same location.
> > > >
> > > > So on upgrade, we probably need to detect the old keys and remove
> > > > them, so they don't get left behind causing problem/confusion.
> > >
> > > Think you can look into this, and probably revise your patch, or as a
> > > follow-up patch, peso?
> >
> > I would prefer to punt this till the next release. There is zero
> > support in the installer for upgrades so this is a non-trivial change.
>
> Sound good.
>
Yep. I'm already working on this follow-up patch. My strategy is a little
different though: To detect an installation and call the uninstaller first.
This is what TortoiseCVS does (they also use Inno Setup), and it nicely
avoids the problem of supporting uninstallation of an "endles" number of old
versions
I agree that this should wait - given my very slow work speed.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Tortoisehg-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
