On Sun, Jul 13, 2008 at 11:06 AM, TK Soh <[EMAIL PROTECTED]> wrote: > On Sun, Jul 13, 2008 at 9:12 AM, Peter Arrenbrecht > <[EMAIL PROTECTED]> wrote: >> On Sun, Jul 13, 2008 at 10:59 AM, TK Soh <[EMAIL PROTECTED]> wrote: >>> On Sun, Jul 13, 2008 at 8:34 AM, Peter Arrenbrecht >>> <[EMAIL PROTECTED]> wrote: >>>> Hi all >>>> >>>> As part of Germáns Google Summer of Code project[1][2], we'd like to >>>> remove the big close buttons from the TortoiseHg dialog toolbars, as >>>> they needlessly duplicate functionality (closing a window). Any >>>> objections? >>> >>> Not me. I've actually thinking to do the same. Apart from the real >>> estate, those 'quit' or 'close' buttons on the toolbars are too much >>> of the hack to maintain. >> >> Excellent. >> >>> My only concern is that whether the users will be comfortable with the >>> idea that they now have to close the button with the 'X' on the window >>> title bar. >> >> I think using the window close button to close something like the log >> view is intuitive. Closing the clone dialog this way less so. But the >> latter should really have [OK] and [Cancel] buttons, like a proper >> dialog. I find it rather confusing to have to hunt down an icon in the >> toolbar to confirm the clone action I just launched. And it doesn't >> play well with the Enter key, either.
Yup, somehow I keep forgetting to fix this problem with the Enter key. > The clone button kicks off a hgcmd dialog to do the cloning. I don't > feel it really works with [OK] and [Cancel] buttons like a 'regular' > dialog. For consistency sake, we should just need to make users be > aware of this GUI change, if we are going ahead with it. > >> Turning the dialog-like windows into proper dialogs is a goal which is >> a bit further away, though. > > No sure I follow you here. > ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Tortoisehg-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
