On Mon, Sep 15, 2008 at 2:06 PM, TK Soh <[EMAIL PROTECTED]> wrote:
> On Mon, Sep 15, 2008 at 12:39 PM, TK Soh <[EMAIL PROTECTED]> wrote:
>> On Mon, Sep 15, 2008 at 9:32 AM, TK Soh <[EMAIL PROTECTED]> wrote:
>>> On Mon, Sep 15, 2008 at 5:14 AM, Peer Sommerlund
>>> <[EMAIL PROTECTED]> wrote:
>>>>
>>>>
>>>> 2008/9/14 TK Soh <[EMAIL PROTECTED]>
>>>>>
>>>>> On Sat, Sep 13, 2008 at 10:30 PM, Peer Sommerlund
>>>>> <[EMAIL PROTECTED]> wrote:
>>>>> >
>>>>> >
>>>>> > 2008/9/14 Peer Sommerlund <[EMAIL PROTECTED]>
>>>>> >>
>>>>> >> 2008/9/12 TK Soh <[EMAIL PROTECTED]>
>>>>> >>>
>>>>> >>> On Thu, Sep 11, 2008 at 7:24 PM, Peer Sommerlund
>>>>> >>> <[EMAIL PROTECTED]> wrote:
>>>>> >>> > I'm wondering if THG should not have some official way to enable /
>>>>> >>> > disable
>>>>> >>> > extensions.
>>>>> >>> >
>>>>> >>> > One usage is for when a dialog needs it, but it is not enabled (like
>>>>> >>> > patchbomb)
>>>>> >>> > Another usage is to enable the user to configure extensions without
>>>>> >>> > editing
>>>>> >>> > hgrc
>>>>> >>> >
>>>>> >>> > This patch is an example of the former: enabling patchbomb when
>>>>> >>> > needed.
>>>>> >>>
>>>>> >>> If the patchbomb extension is _required_ by hgemail, then it should go
>>>>> >>> turn it on by itself, instead of having to burden user.
>>>>> >>>
>>>>> >>> Can you try to see if this patch will do it? I am not sure if the
>>>>> >>> loadall() is really needed though.
>>>>> >>
>>>>> >> It isn't - which brings the patch down to a single line.
>>>>> >>
>>>>> >> Nice and elegant.
>>>>> >>
>>>>> >> I suppose the only way to learn the Mercurial API is to read the code
>>>>> >> ...
>>>>> >> I'll send the patch in another mail.
>>>>> >
>>>>> > Here you go
>>>>>
>>>>> Any reason why the Hg changeset headers are missing from your patch?
>>>>
>>>> Yes, I'm not using hg email, but simply copied the patch file from my MQ.
>>>> I thought this was the preferred way to recieve patches as described on the
>>>> wiki:
>>>> "Please attach the patches as plain text with extension .txt"
>>>
>>> It is the preferred way, but you need to submit the patch in hg export
>>> format. Without the headers, your name and other info will not be
>>> recorded when I hg import your patches.
>>>
>>>> I am a little confused as to how you would like to recieve patches.
>>>> Can you describe it agan? Maybe the wiki text needs an update.
>>>> http://tortoisehg.wiki.sourceforge.net/Submitting+Patches
>>
>> On second thought, since we have convert to Unix line-ending format,
>> attaching the patch files is really necessary any more. The attachment
>
> Typo. I meant to say "_not_ necessary any more".
>
>> way was originally intended prevent the line-ending from being
>> scrambled by the mail client.
>>
>> These days, I simply save the patches from emailed to files, then hg
>> import them. Still troublesome, but it works so far.
>>
>> I will update the wiki page on this.

I've updated the wiki page. Please take a look and let me know if it's
still not clear enough. Feel free to update it too.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Tortoisehg-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to