On Tue, Jan 13, 2009 at 5:24 AM, TK Soh <[email protected]> wrote: > On Tue, Jan 13, 2009 at 4:53 AM, Abdul Halim <[email protected]> wrote: >> On Tue, Jan 13, 2009 at 12:35 PM, TK Soh <[email protected]> wrote: >>> I don't understand. This is redundant. Why not just call util.datetr() >>> directly? Also, the default date format in util.datetr() is not what >>> we want. You should use the format "%Y-%m-%d %H:%M:%S %1%2". >>> >> Maintainability sake. Any changes to tortoisehg date time format will be in >> a single file or location. No need for changes across the board. >> And your requested time format can be changed with a one liner too in this >> way. > > Maintainability is not relevant until the feature has been added. > Please make direct call to util.datestr(), and remove > tortoise/datetime.py.
On second though, it make sense to have a canned function, since we are going to use a custom date format. but please add it into hglib.py (our lib code dealing with hg). The primary use of tortoise directory is to support the explorer shell extentions. ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Tortoisehg-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
