Bugs item #1891211, was opened at 2008-02-11 09:32
Message generated for change (Settings changed) made by sborho
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=968354&aid=1891211&group_id=199155

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: KPTheProf (kptheprof)
Assigned to: Nobody/Anonymous (nobody)
Summary: Can't view revisions if pathnames used.

Initial Comment:
If you have revisions of files in the repository that have path names, then you 
cannot view their revisions from View Changelog on Windows XP SP2 system.

The pathnames are shown using unix forward slash / and not MS back slash \. 
When the file is extracted to the users temporary directory, the file is 
extracted okay including any directory names, but the view revision, doesn't 
have the correct filename. It only shows the name of the revision but none of 
it's leading directory paths, and so cannot find the temporary file to open it.



----------------------------------------------------------------------

Comment By: Doug Philips (dgou)
Date: 2008-04-13 09:40

Message:
Logged In: YES 
user_id=392583
Originator: NO

So this is fixed in 0.4? I'm not sure how to try to repro it myself...
I tried creating a new repo directory "foo bar" and then pulled from an
existing repo with no spaces in its path.
After doing that, the context menu on "foo bar" seemed to work OK... not
sure where to go to set the temporary directory to be used...


----------------------------------------------------------------------

Comment By: KPTheProf (kptheprof)
Date: 2008-02-11 11:38

Message:
Logged In: YES 
user_id=2003806
Originator: YES

The current repository that I'm setting up doesn't have any spaces in the
directory or file names (at the moment because of 1886935), but the
temporary folder does (C:\Documents and Settings\user\Local
Settings\Temp\...)

----------------------------------------------------------------------

Comment By: Steve Borho (sborho)
Date: 2008-02-11 10:53

Message:
Logged In: YES 
user_id=12062
Originator: NO

If your file paths have spaces in them, it will break all the context menu
features
because of 1886935.  I have a patch that fixups the path separators before
passing
the filenames to external tools.

----------------------------------------------------------------------

Comment By: KPTheProf (kptheprof)
Date: 2008-02-11 10:38

Message:
Logged In: YES 
user_id=2003806
Originator: YES

Changing the global repository setting for the visual editor to
<unspecified> allowed me to view the changes (it opens notepad - so it
isn't formatted properly for unix text files), but the save at revision
still doesn't create any file that I can see if you have directory names in
the repository files. 

----------------------------------------------------------------------

Comment By: KPTheProf (kptheprof)
Date: 2008-02-11 10:27

Message:
Logged In: YES 
user_id=2003806
Originator: YES

I'm using the latest version of PSPad which is a free developers editor -
http://www.pspad.com

----------------------------------------------------------------------

Comment By: KPTheProf (kptheprof)
Date: 2008-02-11 10:20

Message:
Logged In: YES 
user_id=2003806
Originator: YES

This problem also seems to effect saving at revisions as well.
If you have a directory name, then you can't seem to extract the file at
all. It's okay if there is no folder name.

I don't know if it's related to bug 1886935 that I submitted earlier
(sorry that that was anonymous, but I hadn't joined sourceforge.net then)

----------------------------------------------------------------------

Comment By: Steve Borho (sborho)
Date: 2008-02-11 10:20

Message:
Logged In: YES 
user_id=12062
Originator: NO

I can see where the problem could occur, and I have a fix for the bad
behavior, but I'm unable to reproduce
the edit failure so I'm not 100% sure that my fix will work for your case.
 Can you tell me what editor you
are using so I can better test my fix?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=968354&aid=1891211&group_id=199155

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Tortoisehg-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to