Issue 1: Vista Overlay Icons constantly appear/disappear http://bitbucket.org/tortoisehg/stable/issue/1/vista-overlay-icons-constantly-appear
Steve Borho / sborho on Thu, 5 Mar 2009 08:05:18 +0100: Comment: Overlay: ThreadingModel registry setting ID: 1895443 It worries me a little bit that TortoiseHg sets the "ThreadingModel"="Both" in the registry for it's overlay handler COM component. "Both" implies that the component can handle free threaded calls (thus will synchronize calls by itself). I haven't connected any current problem to this, but I would suggest to use "ThreadingModel"="Apartment" which tells callers that free thread calls are not allowed, which seems safer to me, given that it appears to me that the TortoiseHg overlay handler code doesn't have any thread synchonisation. As I understand it, COM will synchronize the calls with this setting. I haven't identified explorer.exe to use multiple threads when calling the overlay. But might be good to stay on the save side with regards to the cache in iconoverlay.py. The attached patch would ensure that "ThreadingModel"="Apartment" in the registry. Added attachment: threading.patch -- This is an issue notification from bitbucket.org. You are receiving this either because you are the owner of the issue, or you are following the issue. ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Tortoisehg-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
