Bugs item #1903115, was opened at 2008-02-27 09:18
Message generated for change (Settings changed) made by sborho
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=968354&aid=1903115&group_id=199155

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 7
Private: No
Submitted By: KPTheProf (kptheprof)
Assigned to: Nobody/Anonymous (nobody)
Summary: Qct hangs when commiting large number of additions

Initial Comment:
I've added a large number of files (1194 files and 11 folders) using the "add 
files" successfully, but when I commit the changes, the commit tool hangs after 
pressing the commit button.

I left it running for about an hour before closing the window (it showed as 
"not responding").

When I went back into the "view changelog" the new files were shown as been 
added, but the previous commit that I had done a few days ago (tip 14) appears 
to have been replaced by this commit.

If I run the "add files" again then the files from the tip 14 are listed as 
unknown and I can add them again successfully and commit them.



----------------------------------------------------------------------

Comment By: Ben Houston (bhouston)
Date: 2008-08-25 18:52

Message:
Logged In: YES 
user_id=77981
Originator: NO

> I modified the bug title to avoid mixing up this issue (for Qct) with
the
internal commit dialog.

Ah.  Yeah, I don't know what Qct is.  I just have problems with the
TortoiseHg Commit dialog going unresponsible when dealing with large
commits.  I guess that is somewhat understandable.  This isn't the biggest
issue I've run into -- the biggest is the locking of Explorer.exe and
Open/SaveFileDialogs while browsing and the issue with character casing
making it impossible to update to the latest revision on a different
machine. 

> bhouston: what version of TortoiseHg are you using?

I try to stay up to date.  I was running "version 0.4rc3" until about an
hour ago.  I'm now using the latest.

----------------------------------------------------------------------

Comment By: TK Soh (tksoh)
Date: 2008-08-25 18:45

Message:
Logged In: YES 
user_id=411637
Originator: NO

I modified the bug title to avoid mixing up this issue (for Qct) with the
internal commit dialog.

bhouston: what version of TortoiseHg are you using?

----------------------------------------------------------------------

Comment By: Ben Houston (bhouston)
Date: 2008-08-25 18:13

Message:
Logged In: YES 
user_id=77981
Originator: NO

I have similar issues.  It doesn't hang outright but it goes "Not
Responding" according to windows.  Basically, the commit thread or whatever
needs to call Windows.Update() or Application.DoEvents() or equivalent.

----------------------------------------------------------------------

Comment By: Steve Borho (sborho)
Date: 2008-04-17 11:46

Message:
Logged In: YES 
user_id=12062
Originator: NO

Thank you very much!

It was, indeed, the print statements that are causing all the grief.  I
have removed them from the TortoiseHg version of Qct, since the print
statements are completely worthless anyway.

This will be fixed in the 0.4 release

----------------------------------------------------------------------

Comment By: AndyB (boersmaa)
Date: 2008-04-17 11:38

Message:
Logged In: YES 
user_id=2065842
Originator: NO

I just installed version 4rc1
When selecting a large quantity to commit it hangs.

Running QCT out of a command line I got the following error:
Traceback <most recent call last>:
  File "qctlib\gui_logic.pyc", line 797, in commitSelected
  File "qctlib\vcs\hg.pyc", line 511, in commitFiles
IOError: [Errno 12] Not enough space

Its a windows 2003 server, with all patches, totally uptodate.

Thanks

----------------------------------------------------------------------

Comment By: Steve Borho (sborho)
Date: 2008-04-15 09:15

Message:
Logged In: YES 
user_id=12062
Originator: NO

The Windows installers include the Qct commit tool and they ship with a
Mercurial.ini that selects Qct as the default commit tool.   When you
install from source, you have to install Qct separately if you want to use
it,  otherwise TortoiseHg uses it's internal commit dialog.

http://qct.sourceforge.net/hg/qct

I've also wondered about the buffer overflow.  I would like to comment out
the two print statements in the Qct commit function and see if the
situation improves.  I was going to do this in the next build.

----------------------------------------------------------------------

Comment By: Doug Philips (dgou)
Date: 2008-04-15 07:38

Message:
Logged In: YES 
user_id=392583
Originator: NO

I updated back to 5a5341bda4c5 and it acted still the same under Mac OS
X.
Where do I go to read about the GUI differences under Windows?
I am wondering if all my long path names aren't causing a buffering and/or
pipe write/read deadlock problem? (just a shot in the very dark)


----------------------------------------------------------------------

Comment By: Doug Philips (dgou)
Date: 2008-04-15 07:25

Message:
Logged In: YES 
user_id=392583
Originator: NO

I've tried to repro my failure under Mac OS X with the latest -crew, but
the dialogues are very different. Under windows, when I hit the commit
button I don't get any more windows popping up, but on the Mac I get a
confirmation dialogue and after confirming I get another window that shows
the files being removed. Was that added to -crew after 0.4rc1 was
released?


----------------------------------------------------------------------

Comment By: Doug Philips (dgou)
Date: 2008-04-13 21:32

Message:
Logged In: YES 
user_id=392583
Originator: NO

I'd love to try that out, based on RC2 maybe?
I can get my group to by into clunky for a while, but hanging will look
really bad...


----------------------------------------------------------------------

Comment By: TK Soh (tksoh)
Date: 2008-04-13 20:38

Message:
Logged In: YES 
user_id=411637
Originator: NO

BTW, the earlier message is added by me. I didn't notice I got kicked out
of SF :-(

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2008-04-13 20:25

Message:
Logged In: NO 

If you don't mind the slightly under-par native commit dialog, you can use
it as the 'workaround'. After the bugfix on merged repo, of course.

We will eventually phase out Qct from TortoiseHg.

----------------------------------------------------------------------

Comment By: Doug Philips (dgou)
Date: 2008-04-13 17:46

Message:
Logged In: YES 
user_id=392583
Originator: NO

Sorry for being unclear, it quits just fine.
Exit status of 0.


----------------------------------------------------------------------

Comment By: Steve Borho (sborho)
Date: 2008-04-13 17:39

Message:
Logged In: YES 
user_id=12062
Originator: NO

Once it prints 'No remaining uncommited changes', it should quit.  Is it
not exiting?


----------------------------------------------------------------------

Comment By: Doug Philips (dgou)
Date: 2008-04-13 17:35

Message:
Logged In: YES 
user_id=392583
Originator: NO

Sure. My output was:

-----------------------------------------------------------------------------------------------------------
Removed 253 file(s) from revision control: <pages of output elided>
No remaining uncommited changes
-----------------------------------------------------------------------------------------------------------

The file names of the files removed average around 40 characters each,
plus or minus 15, if that helps any.


----------------------------------------------------------------------

Comment By: Steve Borho (sborho)
Date: 2008-04-13 17:10

Message:
Logged In: YES 
user_id=12062
Originator: NO

I'm afraid that message isn't helpful in this case.  The traceback was
from the context menu and doesn't appear related at all.  The 'Timed Out!!'
message in the previous dump seemed to have been applicable, but it
actually turned out to be from the overlay code as well.

Can you try this from the command line, by opening cmd.exe and running 'hg
qct' inside your repository?  I'm curious if this a) generates any output
or b) works correctly.  It should print two lines of output if it works
correctly:

print "Removed %d file(s) from revision control: %s" 
print "%d file(s) commited: %s"


----------------------------------------------------------------------

Comment By: Doug Philips (dgou)
Date: 2008-04-13 15:49

Message:
Logged In: YES 
user_id=392583
Originator: NO

Sigh, no sooner do I submit the previous entry when I get a back trace.
Maybe this will help?
After submitting the previous entry, I clicked on the desktop (background)
and got this in the tracelog window:

-----------------------------------------------------------------------------------------------------------
idCmdFirst =  30997
pythoncom error: Unexpected exception in gateway method
'QueryContextMenu'

Traceback (most recent call last):
  File "win32com\server\policy.pyc", line 332, in _InvokeEx_
  File "win32com\server\policy.pyc", line 593, in _invokeex_
  File "tortoise\contextmenu.pyc", line 223, in QueryContextMenu
<type 'exceptions.IndexError'>: list index out of range
pythoncom error: Unexpected gateway error

Traceback (most recent call last):
  File "win32com\server\policy.pyc", line 332, in _InvokeEx_
  File "win32com\server\policy.pyc", line 593, in _invokeex_
  File "tortoise\contextmenu.pyc", line 223, in QueryContextMenu
<type 'exceptions.IndexError'>: list index out of range
-----------------------------------------------------------------------------------------------------------


----------------------------------------------------------------------

Comment By: Doug Philips (dgou)
Date: 2008-04-13 15:46

Message:
Logged In: YES 
user_id=392583
Originator: NO

Yes, I was able to repro with tracelog.exe running. Unfortunately it
didn't show anything, here is what I did get (I did a clear before
initiating the commit context menu item:

-----------------------------------------------------------------------------------------------------------
idCmdFirst =  31086
_get_commands() on C:\cygwin\home\PhilipsD\hg\KP2.clone2
run_program: "C:\Program Files\TortoiseHg\hgproc.exe" --command commit
--root "C:\cygwin\home\PhilipsD\hg\KP2.clone2" --listfile
"c:\docume~1\philipsd\locals~1\temp\tortoisehg_filelist_wja1c9"
--deletelistfile --cwd "C:\cygwin\home\PhilipsD\hg\KP2.clone2" --
--verbose
hgproc sys.argv = ['C:\\Program Files\\TortoiseHg\\hgproc.exe',
'--command', 'commit', '--root',
'C:\\cygwin\\home\\PhilipsD\\hg\\KP2.clone2', '--listfile',
'c:\\docume~1\\philipsd\\locals~1\\temp\\tortoisehg_filelist_wja1c9',
'--deletelistfile', '--cwd', 'C:\\cygwin\\home\\PhilipsD\\hg\\KP2.clone2',
'--', '--verbose']
Timed out!!
_get_state: root =  None
_get_state: not in repo
IsMemberOf: _get_state() took 0 ticks
C:\cygwin\home\PhilipsD\hg\KP2.clone2: unknown (cached)
IsMemberOf: _get_state() took 0 ticks
C:\cygwin\home\PhilipsD\hg\KP2.clone2: unknown (cached)
IsMemberOf: _get_state() took 0 ticks
C:\cygwin\home\PhilipsD\hg\KP2.clone2: unknown (cached)
IsMemberOf: _get_state() took 0 ticks
C:\cygwin\home\PhilipsD\hg\KP2.clone2: unknown (cached)
IsMemberOf: _get_state() took 0 ticks
C:\cygwin\home\PhilipsD\hg\KP2.clone2: unknown (cached)
IsMemberOf: _get_state() took 0 ticks
-----------------------------------------------------------------------------------------------------------

The task manager shows two "Qct Commit Tool 1.6-thg" applications with
status "Not Responding"
I don't know what processes to look for in the "Processes" tab.

I recreated this by:
       Modifying a bunch of files programmatically
       Removing a bunch of files (but not telling hg, I just removed the
files).
       In the commit window the modified files were already selected and
the missing files were not, so I clicked the "(Un)Select All" button and
scrolled down to make sure that the '!' files were also selected.
       Entered a short Commit Message.
       Clicked on the "Commit" button.
Got the hourglass and no action from the window.


----------------------------------------------------------------------

Comment By: Steve Borho (sborho)
Date: 2008-04-13 12:31

Message:
Logged In: YES 
user_id=12062
Originator: NO

Any chance you can reproduce this with tracelog.exe running?  When python
GUI apps hang like this they usually output a backtrace.

----------------------------------------------------------------------

Comment By: Doug Philips (dgou)
Date: 2008-04-13 10:15

Message:
Logged In: YES 
user_id=392583
Originator: NO

Which is the work-around for what?
This is going to be a big problem for adoption in my group. :(
What can I do to help diagnose it?


----------------------------------------------------------------------

Comment By: Doug Philips (dgou)
Date: 2008-04-12 19:03

Message:
Logged In: YES 
user_id=392583
Originator: NO

I've seen this one in 0.4rc1... 


----------------------------------------------------------------------

Comment By: TK Soh (tksoh)
Date: 2008-04-05 11:45

Message:
Logged In: YES 
user_id=411637
Originator: NO

TortoiseHg's built-in commit dialog, scheduled for 0.4, has seen some
improvement. Though still not nearly as good as Qct, it may be used a
temporary 'workaround'.


----------------------------------------------------------------------

Comment By: Doug Philips (dgou)
Date: 2008-04-05 07:51

Message:
Logged In: YES 
user_id=392583
Originator: NO

Any chance of seeing this addressed in 0.4 (The roadmap is a little vague
about Qct...)


----------------------------------------------------------------------

Comment By: JWells (jw113)
Date: 2008-03-08 14:42

Message:
Logged In: YES 
user_id=2026141
Originator: NO

I had the same problem committing a new project with 1278 files/225
folders, using TortoiseHg 0.3 with the default Qct commit interface. After
clicking on "Commit" Qct stopped responding; hgproc.exe CPU activity showed
that it had finished after 10s or so, but Qct remained "not responding" for
a further 10mins, until I terminated it. Recovery->Verify showed that the
commit had succeeded.

I tested the same commit using the internal commit option, and it worked
fine. It also showed the progress of the commit, unlike Qct. 

----------------------------------------------------------------------

Comment By: TK Soh (tksoh)
Date: 2008-03-05 03:40

Message:
Logged In: YES 
user_id=411637
Originator: NO

Can you try to use the built-in commit dialog by commenting out
tortoisehg.commit in your mercurial.ini or ~/.hgrc, to see if the same
problem applies?

----------------------------------------------------------------------

Comment By: KPTheProf (kptheprof)
Date: 2008-03-05 03:29

Message:
Logged In: YES 
user_id=2003806
Originator: YES

I am using 0.3 and I'm using the commit tool that comes with 0.3 as it's
configured in the installation which is Qct Commit Tool 1.6-thg

----------------------------------------------------------------------

Comment By: TK Soh (tksoh)
Date: 2008-02-28 18:58

Message:
Logged In: YES 
user_id=411637
Originator: NO

There was a typo in my earlier comment: 

  s/glog/gcommit/

----------------------------------------------------------------------

Comment By: TK Soh (tksoh)
Date: 2008-02-28 09:38

Message:
Logged In: YES 
user_id=411637
Originator: NO

Just to be really sure, are you using the built-in commit tool (glog) or
Qct?

And I presume you are using TortoiseHg 0.3?

----------------------------------------------------------------------

Comment By: TK Soh (tksoh)
Date: 2008-02-27 09:28

Message:
Logged In: YES 
user_id=411637
Originator: NO

I wonder how long it would take, had you committed the same files on CLI:

   C:\repo> hg --time ci -m"your message"


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=968354&aid=1903115&group_id=199155

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Tortoisehg-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to