On Thu, Apr 23, 2009 at 10:34 PM, Adrian Buehlmann <[email protected]> wrote: > On 23.04.2009 23:10, Adrian Buehlmann wrote: >> On 23.04.2009 02:42, TK Soh wrote: >>> Just a thought. If Adrian can get the folders to show the overlay >>> icons quickly, perhaps we can slot in this overlay icons extension, >>> while waiting for or in case we can't get the 'official' C++ shellext >>> ready for 0.8. >> >> (1) >> Overlay icons on folders currently looks like a harder nut to me, so don't >> expect anything quickly (if at all). I might play with it if I'm bored enough >> (and not distracted by other -- non Mercurial -- stuff popping up). > > Oh, wait. > > http://bitbucket.org/bfrog/cutehg-crew/src/fe85ceaf5084/win32/shellext/dirstate.c#cl-263 > > looks very cute indeed. Nice work by Benjamin Pollack. > > For directories, he just iterates over all dirstate entries as well, matching > part of > the path and seeing if there is an added / modified file inside. > > Add wins over modified.
I think 'modified' is a better state over 'add', since the folder is considered modified when new files are added. But, that's just a minor detail for now. > That should give nearly the same speed for directories as for the files alone, > I suspect. If it's going to scan through the dirstate entries like it does on the files, then the worst-case overhead should be the same. The difference is that it has to always scan the whole dirstate to get the status on folders, so folder always get the worst-case impact. I think. > I'm going to grab that ;-) ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensign option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Tortoisehg-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
