On Wed, Apr 29, 2009 at 10:22 AM, Trey Roessig <[email protected]> wrote:
> On Wed, Apr 29, 2009 at 7:58 AM, Steve Borho <[email protected]> wrote:
>> On Wed, Apr 29, 2009 at 12:22 AM,  <[email protected]> wrote:
>>> Please double check the "ui refresh" code in _msg_config.  This seems
>>> to be the pattern used elsewhere, but it makes me nervous.  Also,
>>> please note that I've got the config set at the repo, not global, level.
>>
>> Pushed.
>>
>> The ui refresh code is fine for now, I'll probably revisit that
>> project wide after
>> 1.3 is released and the new ui class is settled.
>>
>> As for configuring local or repo, that is also ok for now.  I would like to 
>> fix
>> that issue in a more general way as well.
>>
>> Two small issues that need to be addressed:
>>
>> 1) In thgconfig you need to document the default behavior of those two 
>> settings.
>> ie: they default to 0, which implies no enforcement.
>
> I'll fix that up today.
>
>> 2) the word wrap algorithm is adding whitespace to the end of each line.
>
> This was actually deliberate.  When someone backspaces from the
> beginning of the next line, the single added space will still separate
> the words.  Happy to axe it if you feel that is best.

Hmm.  It took me by surprise, so I lean against it.  But, wait a day
or so and if someone else speaks up in favor of it I can live with it.

--
Steve Borho

------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations 
Conference from O'Reilly Media. Velocity features a full day of 
expert-led, hands-on workshops and two days of sessions from industry 
leaders in dedicated Performance & Operations tracks. Use code vel09scf 
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
_______________________________________________
Tortoisehg-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to