On 19.05.2009 10:15, Adrian Buehlmann wrote: > On 19.05.2009 09:27, Fabian Triefenbach wrote: >> Hello, >> >> I just tried the current nightly build on a 32 bit vista and the context >> menu was not complete and behind the menus were wrong functionalities. >> “View Changelog” opened a filter dialog i.e. >> >> Did I missed some important step before install? First time I tried a >> crew build :) I removed old version, then: reboot, install, reboot. > > I just downloaded and installed > http://tortoisehg-nightly.googlecode.com/files/TortoiseHg-090519.exe > on WinXP pro SP3 > > Context menu looks ok (I tried inside repo trees), but when I select > a menu entry, nothing happens. > > In DebugView, I see > > [2468] [THG] LaunchCommand: "C:\Program Files\TortoiseHg\hgtk.cmd" log > [2468] [THG] LaunchCommand: failed to launch > > (I selected "View Changelog" from the submenu) > > There was no file 'hgtk.cmd' in 'C:\Program Files\TortoiseHg'. > > I then manually created that file 'hgtk.cmd' in 'C:\Program Files\TortoiseHg' > containing the single line > > hgtk.exe %* > > and now the dialogs are appearing as they should.
I just committed the patch below, which fixes it. I tried pushing it to http://bitbucket.org/abuehl/thg-crew/ but the site is currently unresponsive. # HG changeset patch # User Adrian Buehlmann <[email protected]> # Date 1242722386 -7200 # Node ID dbb7d7a6ea5ff3ee465b3fc383a5bfd656423685 # Parent 46a67d78cf982eb96822b20e948063d083635829 shellext/ContextMenu: fixed: dialogs failed to start from context menu Don't use quotes when calling FindFirstFileA. diff --git a/win32/shellext/ContextMenu.cpp b/win32/shellext/ContextMenu.cpp --- a/win32/shellext/ContextMenu.cpp +++ b/win32/shellext/ContextMenu.cpp @@ -372,16 +372,16 @@ void CShellExt::DoHgtk(const std::string TDEBUG_TRACE("DoHgtk: THG root is empty"); return; } - std::string hgcmd = Quote(dir + "\\hgtk.exe"); + std::string hgcmd = dir + "\\hgtk.exe"; WIN32_FIND_DATAA data; HANDLE hfind = FindFirstFileA(hgcmd.c_str(), &data); if (hfind == INVALID_HANDLE_VALUE) - hgcmd = Quote(dir + "\\hgtk.cmd"); + hgcmd = dir + "\\hgtk.cmd"; else FindClose(hfind); - hgcmd += " " + cmd; + hgcmd = Quote(hgcmd) + " " + cmd; std::string cwd; if (!myFolder.empty()) ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Tortoisehg-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
