On Mon, May 25, 2009 at 10:56 PM, Peer Sommerlund <[email protected]> wrote: > > > 2009/5/25 Yuki KODAMA <[email protected]> >> >> On Mon, May 25, 2009 at 7:05 PM, Peer Sommerlund >> <[email protected]> wrote: >> > >> > >> > 2009/5/24 Yuki KODAMA <[email protected]> >> >> >> >> # HG changeset patch >> >> # User Yuki KODAMA <[email protected]> >> >> # Date 1243187015 -32400 >> >> # Node ID f24d52e19d130c5bd5582a166fd5a47b552ca23a >> >> # Parent e63b33ef3201bc8f5a6763058e314b0672c2f9f5 >> >> i18n: change encoding of translated message for command-line >> >> >> >> With this changes, TortoiseHg can be shown the help >> >> text correctly ('hgtk help' command). >> >> 'agettext' is THG own function, means 'a(scii)gettext'. >> > >> > Since the function is aliased to _ why not call it asciigettext ? >> > >> >> It's just for naming consistency. >> In gettext functions, there is 'ugettext' function. >> 'u' means 'unicode', so I've give the name with prefix 'a'. >> But if you feel it kindless, I'm ok to rename it. > > If there is an established naming convention you should follow that. > I'm not that familiar with the gettext API, so my comment was from a purely > idealistic point of view: Longer names leaves fewer possibilities for > interpretation. > Regards, > Peer
Year, I agree that point of view mostly, but I don't want to say meaning of 'ascii' clearly as function name. Because 'agettext' have possibilities of returning non-ascii characters; 'ansi'. As you may know, 'ascii' + others = 'ansi'. regards, Yuki ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://www.creativitycat.com _______________________________________________ Tortoisehg-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
