On Fri, Jun 12, 2009 at 6:56 PM, Steve Borho<[email protected]> wrote:
> On Fri, Jun 12, 2009 at 5:59 PM, Adrian Buehlmann<[email protected]> wrote:
>> On 13.06.2009 00:25, Steve Borho wrote:
>>> On Fri, Jun 12, 2009 at 5:09 PM, Adrian Buehlmann<[email protected]> wrote:
>>>> On 13.06.2009 00:04, Adrian Buehlmann wrote:
>>>>> On 12.06.2009 23:54, Giampaolo Fadel wrote:
>>>>>> I understood!
>>>>>> The problem is the different key name.
>>>>>> In my pc is S-1-5-21-1390067357-1604221776-725345543-1003
>>>>>> instead of S-1-5-21-1993962763-57989841-839522115-1003.
>>>>>>
>>>>>> Changing the reg file with the first number all works fine.
>>>>>>
>>>>>> Now we have to understand the these name and study a general solution.
>>>>>>
>>>>> [HKEY_USERS\S-1-5-21-1993962763-57989841-839522115-1003\Software\TortoiseHg]
>>>>> "CMenuLang"="en_US"
>>>>>
>>>>> seems useless, as S-1-5-21-1993962763-57989841-839522115-1003 is the SID 
>>>>> [1]
>>>>> for the user, which is only valid on a single PC
>>>>>
>>>>> [1] http://en.wikipedia.org/wiki/Security_Identifier
>>>>>
>>>> HKEY_CURRENT_USER\Software\TortoiseHg
>>>>
>>>> should probably used instead
>>>
>>> Now I find myself wondering how this file ended up with HKEY_USERS in
>>> the first place.  When I added these keys manually the first time I
>>> put them in the same location as the other shell menu variables, which
>>> are created under HKEY_CURRENT_USER.
>>>
>>> I guess when I asked regedit to save my registry keys it did this
>>> mapping to HKEY_USERS implicitly?
>>
>> Doesn't happen here. Using
>>
>> Microsoft Registry Editor
>> Version 5.1 (Build 2600.xpsp_sp3_gdr.09026-1234: Service Pack 3
>>
>> I haven't looked into how this is supposed to be installed.
>> But another question is: the installer must be run from an account
>> in the admin group. Some logins are not admins, so HKEY_CURRENT_USER
>> of admin is not the one the normal user will have (HKEY_CURRENT_USER
>> depends on who is logged in, Windows maps one of HKEY_USERS in there).
>>
>> I haven't thought about how this languages thing should work
>> (was absorbed by enough other things :), but maybe a file per language
>> containing the strings, picked and loaded at runtime (depending on a
>> config setting, with a sane default if absent) would be easier for
>> installing.
>
> For 0.8, these translation files for the cmenu were not going to be
> included with the installer.  Instead they were going to be
> downloadable from our wiki so each user could install just the one(s)
> they need.
>
> For later releases we may get these translations from the RPC server
> or some other semi-clever approach.
>
> It sounds like we can rescue this interim approach by changing the reg
> files to use HKEY_CURRENT_USER instead of HKEY_USERS/SID/

I understand what happened now, it was all my fault initially in the
way I added the keys.   I've modified the three checked in .reg files
to use HKEY_CURRENT_USER and removed the leading 'HG' from the commit
strings while I was at it (based on a recent change to the cmenu
code).

I'm not sure my text editor did the right thing with the Japanese
file, so please send me fixes, Yuki, if that file is botched.

--
Steve Borho

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Tortoisehg-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

Reply via email to