To make a long story short I will just be impolite and buzz in and make complaints and comments without having done proper research. Please shoot back and let me know what you think.
TortoiseHg uses hggtk and thgutil from the python package namespace without any good reasons. Please place all the the libs below the tortoisehg namespace - which also happens to be the name used by the egg.
It is a bit confusing that the rpm package "tortoisehg" mainly provides a binary called "hgtk". Perhaps it would be an idea to introduce the name "thg" and slowly move to that and deprecate "hgtk"?
A unix commandline tool like "hgtk" shouldn't fork. We need a way to disable that by default, prefably without patching the code. A setting in "__paths__.py" would be fine.
Is names like "__paths__.py" really a good idea? That kind of names are reserved for Python, for example there is thgutil.__path__ which is confusingly close to thgutil.__paths__. I would suggest using "custom.py" or "config.py" instead.
When building an rpm then the steps source preparation, building and installing should be separated, so I would like to create "thgutil/__paths__.py" before running setup.py. Could setup.py be taught to only create/overwrite the file when told so?
setup.py installs locale file with an extra locale in the path, such as /usr/share/locale/locale/da/LC_MESSAGES/tortoisehg.moWith that fixed localication works, but slightly annoying messages indicatest that there might be a real problem:
[...@localhost tortoisehg-crew]$ LANG=da hgtk --nofork log
(process:8174): Gtk-WARNING **: Locale not supported by C library.
Using the fallback 'C' locale.
Is that seen on other platforms too?
And finally a windowsism-crash from running vdiff:
** Please report this bug to [email protected] or
http://bitbucket.org/tortoisehg/stable/issues
** Mercurial version (7951f385fcb7). TortoiseHg version (96f7aaae3e59) ** Command: --nofork vdiff ** CWD: /home/mk/tortoisehg-crew ** Extensions loaded: patchbomb, graphlog, mq, extdiff Recoverable runtime error (stderr): Traceback (most recent call last):File "/usr/lib/python2.6/site-packages/hggtk/visdiff.py", line 215, in rowactivated
self.launch(*model[paths[0]])
File "/usr/lib/python2.6/site-packages/hggtk/visdiff.py", line 241,
in launch
except (WindowsError, EnvironmentError), e:
NameError: global name 'WindowsError' is not defined
It is slightly annoying/confusing that no indication of problems is
shown before the dialog is closed. If shit happens then I would prefer
to be informed ASAP.
And some minor comments from my quick test as thg newbie:The About/License window looks bad when the GPL text already is linewrapped and it is shown in a window smaller than the wrapping. Could the window be made twice as wide?
"hgtk add" apparently adds all unknown files? The help text is not very helpful. What can it do that "hg addremove" can't?
Esc closes some dialogs, e.g. userconfig. That is nice. But my fingers gets confused when they can't close other windows which looks like temporary dialogs. I would expect Esc to close most dialogs - perhaps except for the commit dialog with a pending message.
/Mads
smime.p7s
Description: S/MIME Cryptographic Signature
------------------------------------------------------------------------------ Are you an open source citizen? Join us for the Open Source Bridge conference! Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250. Need another reason to go? 24-hour hacker lounge. Register today! http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org
_______________________________________________ Tortoisehg-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
