On 23.08.2009 05:49, Yuki KODAMA wrote: > On Sun, Aug 23, 2009 at 06:14, Adrian Buehlmann<adr...@cadifra.com> wrote: >> On 22.08.2009 19:50, Adrian Buehlmann wrote: >>> # HG changeset patch >>> # User Adrian Buehlmann <adr...@cadifra.com> >>> # Date 1250963282 -7200 >>> # Branch stable >>> # Node ID c54c4ab2da9d6fc68eca51c07241dbfa04c2da05 >>> # Parent 2e318553be7e491132544e0c4ec9976047423a47 >>> shellext: use wide strings for UI texts in ContextMenu.cpp >> Just tested with the current stable Japanese regfile... >> >> Looks like it works: >> http://cdn.bitbucket.org/abuehl/thg-abuehl/downloads/jp-cmenu.png >> >> (but please don't ask me what those entries mean :) >> >> At least I figured out how to teach my English Windows XP to take >> a menu font that can show Japanese glyphs (I found and choose >> "Arial Unicode MS" -- looks ugly, but seems able to show jp chars). > > Very thanks, Adrian. The patch works good with Explorer.exe. > However, it doesn't work with the application "X-Finder" (integrate > with shell extension) > that requests ANSI help text. > This means "GCS_HELPTEXTW" is OK (Explorer.exe): > > [2952] [THG] CShellExt::GetCommandString: idCmd = 0, uFlags = 5 > (GCS_HELPTEXTW), cchMax = 600 > [2952] [THG] CShellExt::GetCommandString: name = "commit" > [2952] [THG] CShellExt::GetCommandString: res = 0, pszName (wide) = > "変更点をリポジトリにコミットします" >
Explorer always asks for a wide help text, falling back to asking a second time for an ANSI text if the shell extension returns an error on the first attempt. It seems a bit strange for "X-Finder" not to do the same. Isn't that application specifically supposed to work with non-western languages? > but "GCS_HELPTEXTA" is NG (X-Finder): > > [2300] [THG] CShellExt::GetCommandString: idCmd = 0, uFlags = 1 > (GCS_HELPTEXTA), cchMax = 201 > [2300] [THG] CShellExt::GetCommandString: name = "commit" > [2300] [THG] CShellExt::GetCommandString: res = 0, pszName = "" Yeah. I thought it doesn't make much sense to try squeezing an ANSI text out of a wide help string and decided not to bother much about that case and just return an empty string. > It shows context menu label correctly, but doesn't show help text, it was > empty. > I'd like to fix this issue and send as a patch later. Sure. Send a patch on top of mine. Or push both patches to a bitbucket repo. Just tell Steve when it's ready for pushing to the official repo. I'll happily leave this up to you, as you are using Japanese UI yourself (which is a good test). BTW, I'm not interested in installing X-Finder here, so I won't do tests with that. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
