On Tue, Sep 29, 2009 at 03:34, Steve Borho <st...@borho.org> wrote: > On Mon, Sep 28, 2009 at 1:01 PM, Yuki KODAMA <endflow....@gmail.com> wrote: >> On Tue, Sep 29, 2009 at 02:50, Henrik Stuart <h...@hstuart.dk> wrote: >>> # HG changeset patch >>> # User Henrik Stuart <h...@hstuart.dk> >>> # Date 1254153381 -7200 >>> # Node ID b9d6743f25c2e1fa8cabe63e90f7b40c4de70ec1 >>> # Parent b012c6819dd06abaaf5f485592b8abdfa87764d5 >>> history: add ctrl+g handler for navigating to revision >> >> I also hope this shortcut, but unfortunately, Ctrl-G accelerator is already >> used by TreeView to search next match: >> http://tortoisehg.bitbucket.org/manual/0.8/common.html#treeview-searches > > I tested with this patch applied, and it seems GTK+ is able to handle > a CTRL-G accelerator on the treeview separately from the CTRL-G > accelerator on the find window. When the find window is open, CTRL-G > does a search-next. When the window is not open, CTRL-G opens the > 'goto rev' window.
Cool. I didn't test it yet. Thanks. > So the question is: Does a dual-function accelerator outweigh chosing > a less standard accelerator for 'goto'? I don't prefer implicit dual-function accelerator. The chance to use CTRL-G (for searching next match) is rarely since Changelog viewer has filter bar and it's easy to filter & search changesets. (In fact, I didn't use CTRL-F/G after introduced filter bar) BTW, CTRL-F is very popular shortcut in a ton of application, but CTRL-G is not so. While I'm not familiar with GTK+ convention, I suppose the right way for me is: * drop CTRL-G shortcut for "next match" * assign CTRL-G for "goto_rev" * introduce search bar (see below) I have a idea to provide more functional search box to LogView, looks like Firefox's "In-Page" search bar showed at the bottom of the page with CTRL-F. And "next match" feature is provided as button in the search bar, or Enter key in the search box. If LogView gets this, it doesn't need to assign CTRL-G for "next match". As a result, CTRL-G won't conflict with "next match" feature. -- Yuki KODAMA ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
