On Tue, Sep 29, 2009 at 12:48 PM, Diego Oliveira <loki...@gmail.com> wrote:
> Hello,
>
> On Tue, Sep 29, 2009 at 1:27 PM, Steve Borho <st...@borho.org> wrote:
>
>> On Tue, Sep 29, 2009 at 10:56 AM, Diego Oliveira <loki...@gmail.com>
>> wrote:
>> > Hello,
>> >
>> > Follows attached the patch to put arrows beside the bubbles based on
>> the
>> > incoming/outgoing state. I'm
>> > behind a firewall and wasn't possible to send via TortoiseHG email
>> function.
>> >
>> > Image: http://bitbucket.org/m/attch/2009/09/history.png
>>
>> These are very promising, but there's a few issues.
>>
>> * The other revision graph generators need to be changed to also yield
>> the status field.
>>
> * It confuses 'incoming' changesets with 'new' changesets.
>>
>
> I didn't understand your point. I found now that the order you do the
> operation leave to different
> results, but I think the bug isn't in my implementation.
>
If you commit a change while the changelog tool is open, it will show up as
'incoming' after a refresh instead of just being 'new'.
> Original clone:
> a----b----c
>
> My change
> a----b----c----d
>
> Change to the original repo
>
> a----b----c----e
>
> If I do a outgoing and then a incoming, the graph look likes
> a----b----c----d (->)
> \
> +----e (<-)
>
> But if I revert the operation order I get.
> a----b----c----d
> \
> +----e (<-)
>
> I think this is happening because the outgoing variable in treeview.py
> isn't actualized after the incoming,
> I'll take a look in this tomorrow.
>
Once you do an 'incoming', you can't really do any more repository
operations without doing a 'reset marks' first. It's doing a bundle overlay
that interferes with most repository operations. The history browser needs
to be mostly disabled when it is showing a bundle overlay.. until the user
either accepts (pulls) the bundle changes or rejects them.
This wasn't caused by your change at all, it's mostly my fault. The support
for viewing bundle overlays is incomplete, and it needs to be differentiated
internally from 'new' changesets.
BTW: I noticed the 'status' comment was wrong as well, you use -1, 0, +1 but
the comment describes 0, 1, 2.
Cheers,
--
Steve Borho
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
