On 30.10.2009 12:57, Yuki KODAMA wrote:
> On Fri, Oct 30, 2009 at 19:17, Adrian Buehlmann <adr...@cadifra.com> wrote:
>> On 30.10.2009 10:03, Yuki KODAMA wrote:
>>> # HG changeset patch
>>> # User Yuki KODAMA <endflow....@gmail.com>
>>> # Date 1256886743 -32400
>>> # Branch stable
>>> # Node ID 4b477c4fa4e2b911059c7efd3c9c9233e5546838
>>> # Parent 171990177c086cab7ce964bfebe518c0c8f69d04
>>> changeset: move branch name to summary label
>>>
>>> Remove brackets of branch name and unexpected rev jump.
>>> If branch name is embedded in rev label, it will be the cause
>>> of unexpected 'revision jump' on click.
>>>
>>> diff --git a/tortoisehg/hgtk/changeset.py b/tortoisehg/hgtk/changeset.py
>>> --- a/tortoisehg/hgtk/changeset.py
>>> +++ b/tortoisehg/hgtk/changeset.py
>
> {snip}
>
>>> - text = gtk.Label(summary)
>>> + # body label
>> Why are you using the word "body" in this comment?
>>
>> Isn't this the summary you are dealing with below?
>
> I thought:
> "body" = "branch name" + "summary text"
>
I think
# summary label
would be better. The branch is just an add-on for the
summary label.
Or at least be explicit and write:
# summary text and branch name
Remember, we are in function
def get_body(self):
So please let's not invent yet another "body" there that appears
only as a (highly confusing for me) comment.
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Tortoisehg-develop mailing list
Tortoisehg-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
