On Sat, Oct 31, 2009 at 17:24, Adrian Buehlmann <adr...@cadifra.com> wrote: > On 31.10.2009 03:57, Yuki KODAMA wrote: >> On Sat, Oct 31, 2009 at 11:44, Steve Borho <st...@borho.org> wrote: >>> On Fri, Oct 30, 2009 at 8:32 PM, Yuki KODAMA <endflow....@gmail.com> wrote: >>>> On Sat, Oct 31, 2009 at 09:50, Adrian Buehlmann <adr...@cadifra.com> wrote: >>>>> On 30.10.2009 16:02, Yuki KODAMA wrote: >>>>>> # HG changeset patch >>>>>> # User Yuki KODAMA <endflow....@gmail.com> >>>>>> # Date 1256914480 -32400 >>>>>> # Branch stable >>>>>> # Node ID 27e21b1b85614212488b69803317d864e5aa38d8 >>>>>> # Parent d0f9889b4487119518662e1780ea2a90d04c094c >>>>>> changeset: reset scroll positions of diff pane >>>>>> >>>>>> diff --git a/tortoisehg/hgtk/changeset.py b/tortoisehg/hgtk/changeset.py >>>>>> --- a/tortoisehg/hgtk/changeset.py >>>>>> +++ b/tortoisehg/hgtk/changeset.py >>>>>> @@ -232,6 +232,12 @@ >>>>>> else: >>>>>> self.append_all_patch_diffs() >>>>>> >>>>>> + # reset position of diff pane's scroll bar >>>>>> + adj = self.diffscroller.get_vadjustment() >>>>>> + adj.set_value(0) >>>>>> + adj = self.diffscroller.get_hadjustment() >>>>>> + adj.set_value(0) >>>>>> + >>>>>> def generate_change_header(self): >>>>>> self.summarypanel.update(self.currev, self.csetstyle) >>>>>> self.summarybox.show() >>>>>> @@ -424,6 +430,7 @@ >>>>>> scroller = gtk.ScrolledWindow() >>>>>> scroller.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC) >>>>>> details_frame.add(scroller) >>>>>> + self.diffscroller = scroller >>>>>> >>>>>> details_box = gtk.VBox() >>>>>> scroller.add_with_viewport(details_box) >>>>>> >>>>> (was pushed as >>>>> http://bitbucket.org/tortoisehg/stable/changeset/160f9f9a458c/) >>>>> >>>>> I have to say: I prefer the old behavior. >>>> Before your favorite, please accept the fact that old behavior is buggy. >>>> >>>>> Now, if I select a different file on the left, I have to scroll again >>>>> over the changeset message to see the diff. >>>>> >>>>> Can we have the old behavior back or do we need to introduce >>>>> yet another config option? >>>> Hmm... it's a bit overkill I think. >>>> Because you already have "Use expander" option to collapse changeset >>>> header, and it's stored folding state. So even if it resets scroll >>>> position, >>>> you can get enough space for diff text with that option. >>>> Collapsed header just eats approx. 20px height. > > It's not about the header, it is about the change message. > > For short change messages it is not a problem, but try using it with > changesets having longer change messages and multiple changed files > (longer change messages = more than ~7 lines of text).
Ah, I see. >>>> I'll wait other comments (Steve? Sune? or anyone?). >>> I would like it to reset when a new changeset is selected. Not so >>> much for each file selection. >>> >>> -- >>> Steve Borho >>> >> >> You mean no need to reset when the file selected in same changeset? >> > > Yes, that's what he wrote. I agree with Steve. > > I agree with: > > Reset the scroll position if a new changeset is selected, > but don't reset it when just an another file in the same changeset > is selected. I'll submit a patch for this. -- Yuki KODAMA ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
