On 23.11.2009 14:16, Adrian Buehlmann wrote: > On 23.11.2009 12:43, Sune Foldager wrote: >> Adrian Buehlmann wrote: >>> Please pull the changes up to 8ad6cf24d2fb (listed below) from >>> http://bitbucket.org/abuehl/thg-abuehl/ into STABLE. >>> >>> [...] >>> I recommend to pull these changes into the STABLE branch. >>> These changes are not supposed to fix any existing bugs. >> Maybe I misunderstood something, but how can 'stable' be the right place >> to push stuff which doesn't fix bugs but introduces a large number of >> potentially buggy (nothing personal, but that's a lot of changes) code >> changes and even requires uninstall in order to upgrade to. >> > > Why do you think it requires uninstall? > > I think it does not. >
Just checked again. The changes needed in the registry only add new entries or change existing entries. Nothing needs to be removed. http://bitbucket.org/tortoisehg/stable/diff/contrib/win32/registry.iss?diff2=3800d1a4cbc6&diff1=8c289fc850e9 The only thing that doesn't work is compiling and linking the new dll and putting the new dll in place without running the installer. I normally do this myself when developing the shell extension (replacing the dll manually without running the installer). I really would like to have the menu handler COM server off splitting released with 0.9.1. I think the risk is worth the benefits: * Much cleaner code structure, which hopefully will enable some additional changes I am currently pondering. * Demonstration of bug freeness is much improved. * No huge difference in code structure between stable and default branches Frankly, I wouldn't have looked at the shell extension stable branch any more if this refactoring would not have been accepted for stable. I have spent quite a couple of hours on Sunday trying to wrap my head around the explorer crashes reported by some user. I pondered over the code and this mess constantly got in my way. So I cleaned it up. I should have done this already long ago. I don't think the refactoring is that risky. Each single step should be easily reviewable. For me, the clearer structure is well worth the risk pushing it to stable. I don't want to wait another 3 months to have this in a release. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Tortoisehg-develop mailing list Tortoisehg-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop
